-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test related documentation issues #10168
Conversation
See the `Test infrastructure` section below for details. | ||
|
||
Expensive and python tests are not part of CI, and are run by a custom nightly | ||
runner. The results of the latest runs are available | ||
[here](http://nightly.neartest.com/). Today, test runs launch approximately | ||
[here](https://nayduck.near.org/#/). Today, test runs launch approximately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue 1: Incorrect URL for Runner Test Results
@@ -36,19 +36,18 @@ It requires nextest harness which can be installed by running `cargo install car | |||
such tests is to enable all the features by passing `--all-features` to | |||
`cargo nextest run`, e.g: | |||
|
|||
`cargo nextest run --package near-client --test cross_shard_tx | |||
tests::test_cross_shard_tx --all-features` | |||
`cargo nextest run --package near-client -E 'test(=tests::cross_shard_tx::test_cross_shard_tx)' --all-features` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue 2: Non-Existent Test Target Documentation
@@ -63,7 +63,7 @@ want to run tests against a release build, you can create a file with the | |||
following config: | |||
|
|||
```json | |||
{"local": True, "near_root": "../target/release/"} | |||
{"local": true, "near_root": "../target/release/"} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Issue 3: Misguiding Python Tests Documentation
Should we add some tip in python_tests.md to remind people regarding this? |
I think we do not need to add it as it is already there (but in other words):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary:
cargo nextest
command for runningcross_shard_tx
test target.python_tests.md
file already has a guidance about cargo build command for local test runs.Feature guards are test-specific. Depending on what test do we want to run, we should modify the script below accordingly.