Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use clap::ArgEnum for parameter estimator vm kind #8918

Closed
Ekleog-NEAR opened this issue Apr 18, 2023 · 0 comments · Fixed by #9059
Closed

Use clap::ArgEnum for parameter estimator vm kind #8918

Ekleog-NEAR opened this issue Apr 18, 2023 · 0 comments · Fixed by #9059
Labels
C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. C-housekeeping Category: Refactoring, cleanups, code quality

Comments

@Ekleog-NEAR
Copy link
Collaborator

See #8912 (comment)
@Ekleog-NEAR Ekleog-NEAR added the C-housekeeping Category: Refactoring, cleanups, code quality label Apr 18, 2023
This was referenced Apr 18, 2023
Open
Merged
@jakmeier jakmeier added the C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. label Apr 19, 2023
@jakmeier jakmeier mentioned this issue May 15, 2023
Merged
near-bulldozer bot pushed a commit that referenced this issue May 15, 2023
@nagisa
param-estimator: use value_enum for vm_kind (#9059)
c5c0dcc 
This change lets param-estimator automatically pick up new `VMKind`s. But more importantly its just way less error prone now.

Fixes #8918
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-good-first-issue Category: issues that are self-contained and easy for newcomers to work on. C-housekeeping Category: Refactoring, cleanups, code quality
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

param-estimator: use value_enum for vm_kind near/nearcore
2 participants
@jakmeier @Ekleog-NEAR