Tech Debt: get rid of VMConfig::test() #8202
Labels
A-contract-runtime
Area: contract compilation and execution, virtual machines, etc
C-housekeeping
Category: Refactoring, cleanups, code quality
P-low
Priority: low
T-contract-runtime
Team: issues relevant to the contract runtime team
Comments
Ekleog-NEAR
added
C-housekeeping
nagisa
added a commit
that referenced
this issue
Sep 19, 2023
…ration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay!
nagisa
added a commit
that referenced
this issue
Sep 20, 2023
…ration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay!
nagisa
added a commit
that referenced
this issue
Sep 21, 2023
…ration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay!
github-merge-queue bot
pushed a commit
that referenced
this issue
Sep 21, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this issue
Sep 22, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this issue
Sep 26, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this issue
Sep 26, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this issue
Oct 2, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
nikurt
pushed a commit
that referenced
this issue
Oct 2, 2023
…ration (#9539) * remove force_* features and move runtime selection to runtime configuration There are a couple of reasons, but the most major one is that these `force_*` fetures make it impossible to run tools with `--all-features` enabled on macOS (where use of wasmer0 would be forced somewhat arbitrarily.) That said, these options don't make sense, in the world of limited replayability, and with runtime configuration there is also now a fairly straightforward approach to forcing the use of a different runtime than the "default" (just chnge some yamls.) As an upside this also forced my hand to go and fix the Config::test nonsense, a little bit, hence Fixes #8202 and tests will now actually exercise the system in a configuration that is going to run in production most of the time! Yay! * Replace !0 with PROTOCOL_VERSION * Remove the wasmtime feature from runtime-params-estimator * Fix test expectations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
VMConfig::test() makes us run our tests with a configuration that is not the production one.
This means all our tests are less useful than they should be. We should get rid of it and instead use the latest configuration.
The text was updated successfully, but these errors were encountered: