Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

2.1.0-rc.2 congestion gas for a PromiseYield #11873

Closed
Tracked by #11919
evgenykuzyakov opened this issue Aug 1, 2024 · 2 comments · Fixed by #11875
Closed
Tracked by #11919

2.1.0-rc.2 congestion gas for a PromiseYield #11873

evgenykuzyakov opened this issue Aug 1, 2024 · 2 comments · Fixed by #11875

Comments

@evgenykuzyakov
Copy link
Collaborator

Describe the bug
During block catch-up on testnet, the node is spamming:
ERROR congestion_control: Attempting to calculate congestion gas for a PromiseYield.

I'm not sure if it is related only to the sync, or just in general

To Reproduce

  1. Stop node
  2. Wait some time
  3. Start node
  4. Observe the error in the logs

Expected behavior
Do not attempt Or don't show an error.

Screenshots
https://gist.github.com/evgenykuzyakov/0e73c389351367ec1f67c218a34c65b3

Version (please complete the following information):

  • nearcore commit/branch: 2.1.0-rc.2 (+sha disabled)
  • rust version (if local): 1.79.0
  • docker (if using docker): no
  • mainnet/testnet/betanet/local: testnet

Additional context
@bowenwang1996
Copy link
Collaborator

cc @wacban @saketh-are

@wacban wacban mentioned this issue Aug 2, 2024
Merged
@wacban
Copy link
Contributor

wacban commented Aug 9, 2024

JFYI I am removing the error message. It will take a while until it is released though. I will follow up separately to make sure that the promise yield are accounted for in congestion control.

github-merge-queue bot pushed a commit that referenced this issue Aug 9, 2024
@wacban
fix(congestion) - remove error log in promis yield handling (#11875)
658ec13 
There is no need to print an error in this case. Congestion Control does
not need to account for promise yields as indicated in the comment. This
is to fix #11873.
@VanBarbascu VanBarbascu mentioned this issue Aug 9, 2024
Open
@wacban wacban mentioned this issue Aug 12, 2024
Open
jancionear pushed a commit that referenced this issue Aug 16, 2024
@wacban @jancionear
fix(congestion) - remove error log in promis yield handling (#11875)
2089861 
There is no need to print an error in this case. Congestion Control does
not need to account for promise yields as indicated in the comment. This
is to fix #11873.
jancionear pushed a commit that referenced this issue Aug 20, 2024
@wacban @jancionear
fix(congestion) - remove error log in promis yield handling (#11875)
8a5c455 
There is no need to print an error in this case. Congestion Control does
not need to account for promise yields as indicated in the comment. This
is to fix #11873.
jancionear pushed a commit that referenced this issue Aug 21, 2024
@wacban @jancionear
fix(congestion) - remove error log in promis yield handling (#11875)
bdfd736 
There is no need to print an error in this case. Congestion Control does
not need to account for promise yields as indicated in the comment. This
is to fix #11873.
@github-actions github-actions bot mentioned this issue Sep 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(congestion) - remove error log in promis yield handling near/nearcore
3 participants
@evgenykuzyakov @wacban @bowenwang1996