Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Memtrie] Memtrie trie recording needs to capture read nodes during the update code path #10769

Closed
Tracked by #46
robin-near opened this issue Mar 12, 2024 · 0 comments · Fixed by #10841
Closed
Tracked by #46
Assignees
Labels
A-stateless-validation Area: stateless validation

Comments

@robin-near
Copy link
Contributor

Context: https://near.zulipchat.com/#narrow/stream/407237-core.2Fstateless-validation/topic/Missing.20trie.20value

@walnut-the-cat walnut-the-cat added the A-stateless-validation Area: stateless validation label Mar 15, 2024
jakmeier pushed a commit to jakmeier/nearcore that referenced this issue Mar 22, 2024
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
react-router-dom from 6.4.4 to 6.16.0.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **68 versions** ahead of your current
version.
- The recommended version was released **a month ago**, on 2023-09-13.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>react-router-dom</b></summary>
    <ul>
      <li>
<b>6.16.0</b> - <a
href="https://snyk.io/redirect/github/remix-run/react-router/releases/tag/react-router-native%406.16.0">2023-09-13</a></br><p>react-router-native@6.16.0</p>
      </li>
      <li>
<b>6.16.0-pre.2</b> - <a
href="https://snyk.io/redirect/github/remix-run/react-router/releases/tag/react-router-native%406.16.0-pre.2">2023-09-06</a></br><p>react-router-native@6.16.0-pre.2</p>
      </li>
      <li>
        <b>6.16.0-pre.1</b> - 2023-09-05
      </li>
      <li>
        <b>6.16.0-pre.0</b> - 2023-08-28
      </li>
      <li>
        <b>6.15.0</b> - 2023-08-10
      </li>
      <li>
        <b>6.15.0-pre.0</b> - 2023-08-09
      </li>
      <li>
        <b>6.14.2</b> - 2023-07-17
      </li>
      <li>
        <b>6.14.2-pre.1</b> - 2023-07-17
      </li>
      <li>
        <b>6.14.2-pre.0</b> - 2023-07-11
      </li>
      <li>
        <b>6.14.1</b> - 2023-06-30
      </li>
      <li>
        <b>6.14.1-pre.1</b> - 2023-06-30
      </li>
      <li>
        <b>6.14.1-pre.0</b> - 2023-06-29
      </li>
      <li>
        <b>6.14.0</b> - 2023-06-23
      </li>
      <li>
        <b>6.14.0-pre.1</b> - 2023-06-21
      </li>
      <li>
        <b>6.14.0-pre.0</b> - 2023-06-21
      </li>
      <li>
        <b>6.13.0</b> - 2023-06-14
      </li>
      <li>
        <b>6.13.0-pre.1</b> - 2023-06-13
      </li>
      <li>
        <b>6.12.2-pre.0</b> - 2023-06-12
      </li>
      <li>
        <b>6.12.1</b> - 2023-06-08
      </li>
      <li>
        <b>6.12.1-pre.0</b> - 2023-06-08
      </li>
      <li>
        <b>6.12.0</b> - 2023-06-06
      </li>
      <li>
        <b>6.12.0-pre.1</b> - 2023-06-01
      </li>
      <li>
        <b>6.12.0-pre.0</b> - 2023-06-01
      </li>
      <li>
        <b>6.11.2</b> - 2023-05-17
      </li>
      <li>
        <b>6.11.2-pre.0</b> - 2023-05-16
      </li>
      <li>
        <b>6.11.1</b> - 2023-05-03
      </li>
      <li>
        <b>6.11.1-pre.0</b> - 2023-05-02
      </li>
      <li>
        <b>6.11.0</b> - 2023-04-28
      </li>
      <li>
        <b>6.11.0-pre.2</b> - 2023-04-27
      </li>
      <li>
        <b>6.11.0-pre.1</b> - 2023-04-26
      </li>
      <li>
        <b>6.11.0-pre.0</b> - 2023-04-26
      </li>
      <li>
        <b>6.10.0</b> - 2023-03-29
      </li>
      <li>
        <b>6.10.0-pre.2</b> - 2023-03-24
      </li>
      <li>
        <b>6.10.0-pre.1</b> - 2023-03-22
      </li>
      <li>
        <b>6.10.0-pre.0</b> - 2023-03-21
      </li>
      <li>
        <b>6.9.0</b> - 2023-03-10
      </li>
      <li>
        <b>6.9.0-pre.0</b> - 2023-03-08
      </li>
      <li>
        <b>6.8.2</b> - 2023-02-27
      </li>
      <li>
        <b>6.8.2-pre.3</b> - 2023-02-23
      </li>
      <li>
        <b>6.8.2-pre.2</b> - 2023-02-22
      </li>
      <li>
        <b>6.8.2-pre.1</b> - 2023-02-22
      </li>
      <li>
        <b>6.8.2-pre.0</b> - 2023-02-21
      </li>
      <li>
        <b>6.8.1</b> - 2023-02-06
      </li>
      <li>
        <b>6.8.1-pre.0</b> - 2023-02-02
      </li>
      <li>
        <b>6.8.0</b> - 2023-01-26
      </li>
      <li>
        <b>6.8.0-pre.1</b> - 2023-01-24
      </li>
      <li>
        <b>6.7.1-pre.0</b> - 2023-01-24
      </li>
      <li>
        <b>6.7.0</b> - 2023-01-18
      </li>
      <li>
        <b>6.7.0-pre.5</b> - 2023-01-18
      </li>
      <li>
        <b>6.7.0-pre.4</b> - 2023-01-17
      </li>
      <li>
        <b>6.7.0-pre.3</b> - 2023-01-13
      </li>
      <li>
        <b>6.7.0-pre.2</b> - 2023-01-13
      </li>
      <li>
        <b>6.7.0-pre.1</b> - 2023-01-11
      </li>
      <li>
        <b>6.6.3-pre.0</b> - 2023-01-11
      </li>
      <li>
        <b>6.6.2</b> - 2023-01-09
      </li>
      <li>
        <b>6.6.2-pre.0</b> - 2023-01-04
      </li>
      <li>
        <b>6.6.1</b> - 2022-12-23
      </li>
      <li>
        <b>6.6.1-pre.1</b> - 2022-12-22
      </li>
      <li>
        <b>6.6.1-pre.0</b> - 2022-12-22
      </li>
      <li>
        <b>6.6.0</b> - 2022-12-21
      </li>
      <li>
        <b>6.6.0-pre.0</b> - 2022-12-16
      </li>
      <li>
        <b>6.5.0</b> - 2022-12-16
      </li>
      <li>
        <b>6.5.0-pre.1</b> - 2022-12-14
      </li>
      <li>
        <b>6.5.0-pre.0</b> - 2022-12-13
      </li>
      <li>
        <b>6.4.5</b> - 2022-12-07
      </li>
      <li>
        <b>6.4.5-pre.2</b> - 2022-12-06
      </li>
      <li>
        <b>6.4.5-pre.1</b> - 2022-12-06
      </li>
      <li>
        <b>6.4.5-pre.0</b> - 2022-12-05
      </li>
      <li>
        <b>6.4.4</b> - 2022-11-30
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/remix-run/react-router/releases">react-router-dom
GitHub release notes</a>
  </details>
</details>


<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>react-router-dom</b></summary>
    <ul>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/13fb25a51184f66192e023e2e18be5ff00f37827">13fb25a</a>
chore: Update version for release (near#10866)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/d5b9a18abe0077f5829be05aa2a1abce4611c44c">d5b9a18</a>
Exit prerelease mode</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/6bd6fb9d07e6ef9636659beb6b2660cae2a67529">6bd6fb9</a>
chore: Update version for release (pre) (near#10849)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/37c5f3c610d429439c5d79bf9f789451a1caa024">37c5f3c</a>
chore(router): update generic names (near#10845)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/9b1d1843d27d3bc2c749b99740ff4743af64c88e">9b1d184</a>
chore: Update version for release (pre) (near#10844)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/b6614b0e9452708c0880fef46c52fb0e1805eeaf">b6614b0</a>
Add generics for Remix type enhancements (near#10843)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/3069e526d24514e368640ee7ef7e4557b1b323e2">3069e52</a>
chore: Update version for release (pre) (near#10828)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/2dfc178a255ea58f6d83f63e589d0ecb18e8747c">2dfc178</a>
Enter prerelease mode</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/90289d5f02eb2efc8167faf2a0314f14af0a70fb">90289d5</a>
Update changesets files for Remix v2 release</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/c06984dd09d5d861c745877d80d71088f3afdc5b">c06984d</a>
Merge branch &#x27;main&#x27; into release-next</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/c265a42401d6057e400da2446c9eca45d3c93366">c265a42</a>
Prepare for Remix v2 (near#10715)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/9852bb069e385682f58c0cd8eb6732e3f427a39e">9852bb0</a>
name change (near#10812)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/a4495dee75166546dd92a4072fedab30abce84cf">a4495de</a>
Export proper ErrorResponse type (near#10811)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/4cc8eec22867edae7237e49020595e0be5e06334">4cc8eec</a>
Add some redirect unit tests from Remix (near#10810)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/4b494b935d62cd1244fe5c091db920d3f0315e9e">4b494b9</a>
Update route.lazy docs</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/ae75cdc922485988bb21f5b7b450d787204b0787">ae75cdc</a>
Export ShouldRevalidateFunctionArgs interface (near#10797)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/2208703a3fc77673578d7833774cd4c9e029f2ea">2208703</a>
Add method and URL to aborted query/queryRoute error message
(near#10793)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/496b1fe8253643171ecca6e6a945d98386c4eb00">496b1fe</a>
README&#x27;s fixes (near#10775)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/2709b844a6fcb69820ce47cb8df98376692bace4">2709b84</a>
Fix a race-condition with loader/action-thrown errors on route.lazy
routes (near#10778)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/8b3559a50de61a29972ca161a2fccd007441ac58">8b3559a</a>
Encode URIs during server rendering of &lt;a href&gt;/&lt;form
action&gt; to avoi… (near#10769)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/e11af30e806a3921d4ddc654b29e874a9dd6613c">e11af30</a>
Fix actionResult type on shouldRevalidate args (near#10779)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/e254133b3f1daa9247d1b39ed46f77a7ffba5cdc">e254133</a>
[Docs] Fix typo in &#x60;Navigate&#x60; docs (near#10782)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/6a0875773fb09f651f039522195426b0b9cd8910">6a08757</a>
Organize imports (near#10777)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/a0da745ca0379af456f88a19f5abe1d95e101ad4">a0da745</a>
Update examples to latest version</li>
    </ul>

<a
href="https://snyk.io/redirect/github/remix-run/react-router/compare/12e7c2896e5c7cd150e69e8d56d62cc9ed2285dd...13fb25a51184f66192e023e2e18be5ff00f37827">Compare</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIxMDc4MTA3My0zYTMwLTQ5ODAtYTRkZi1jN2MxMDliYWYxNGMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjEwNzgxMDczLTNhMzAtNDk4MC1hNGRmLWM3YzEwOWJhZjE0YyJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/pagoda-pilot/project/12e75fec-70e5-4998-8926-9b5a6351ba5f?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/pagoda-pilot/project/12e75fec-70e5-4998-8926-9b5a6351ba5f/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/pagoda-pilot/project/12e75fec-70e5-4998-8926-9b5a6351ba5f/settings/integration?pkg&#x3D;react-router-dom&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"10781073-3a30-4980-a4df-c7c109baf14c","prPublicId":"10781073-3a30-4980-a4df-c7c109baf14c","dependencies":[{"name":"react-router-dom","from":"6.4.4","to":"6.16.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/pagoda-pilot/project/12e75fec-70e5-4998-8926-9b5a6351ba5f?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"12e75fec-70e5-4998-8926-9b5a6351ba5f","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":68,"publishedDate":"2023-09-13T16:37:49.610Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
jakmeier pushed a commit to jakmeier/nearcore that referenced this issue Mar 22, 2024
<p>This PR was automatically created by Snyk using the credentials of a
real user.</p><br /><h3>Snyk has created this PR to upgrade
react-router-dom from 6.4.4 to 6.16.0.</h3>

:information_source: Keep your dependencies up-to-date. This makes it
easier to fix existing vulnerabilities and to more quickly identify and
fix newly disclosed vulnerabilities when they affect your project.
<hr/>

- The recommended version is **68 versions** ahead of your current
version.
- The recommended version was released **a month ago**, on 2023-09-13.


<details>
<summary><b>Release notes</b></summary>
<br/>
  <details>
    <summary>Package name: <b>react-router-dom</b></summary>
    <ul>
      <li>
<b>6.16.0</b> - <a
href="https://snyk.io/redirect/github/remix-run/react-router/releases/tag/react-router-native%406.16.0">2023-09-13</a></br><p>react-router-native@6.16.0</p>
      </li>
      <li>
<b>6.16.0-pre.2</b> - <a
href="https://snyk.io/redirect/github/remix-run/react-router/releases/tag/react-router-native%406.16.0-pre.2">2023-09-06</a></br><p>react-router-native@6.16.0-pre.2</p>
      </li>
      <li>
        <b>6.16.0-pre.1</b> - 2023-09-05
      </li>
      <li>
        <b>6.16.0-pre.0</b> - 2023-08-28
      </li>
      <li>
        <b>6.15.0</b> - 2023-08-10
      </li>
      <li>
        <b>6.15.0-pre.0</b> - 2023-08-09
      </li>
      <li>
        <b>6.14.2</b> - 2023-07-17
      </li>
      <li>
        <b>6.14.2-pre.1</b> - 2023-07-17
      </li>
      <li>
        <b>6.14.2-pre.0</b> - 2023-07-11
      </li>
      <li>
        <b>6.14.1</b> - 2023-06-30
      </li>
      <li>
        <b>6.14.1-pre.1</b> - 2023-06-30
      </li>
      <li>
        <b>6.14.1-pre.0</b> - 2023-06-29
      </li>
      <li>
        <b>6.14.0</b> - 2023-06-23
      </li>
      <li>
        <b>6.14.0-pre.1</b> - 2023-06-21
      </li>
      <li>
        <b>6.14.0-pre.0</b> - 2023-06-21
      </li>
      <li>
        <b>6.13.0</b> - 2023-06-14
      </li>
      <li>
        <b>6.13.0-pre.1</b> - 2023-06-13
      </li>
      <li>
        <b>6.12.2-pre.0</b> - 2023-06-12
      </li>
      <li>
        <b>6.12.1</b> - 2023-06-08
      </li>
      <li>
        <b>6.12.1-pre.0</b> - 2023-06-08
      </li>
      <li>
        <b>6.12.0</b> - 2023-06-06
      </li>
      <li>
        <b>6.12.0-pre.1</b> - 2023-06-01
      </li>
      <li>
        <b>6.12.0-pre.0</b> - 2023-06-01
      </li>
      <li>
        <b>6.11.2</b> - 2023-05-17
      </li>
      <li>
        <b>6.11.2-pre.0</b> - 2023-05-16
      </li>
      <li>
        <b>6.11.1</b> - 2023-05-03
      </li>
      <li>
        <b>6.11.1-pre.0</b> - 2023-05-02
      </li>
      <li>
        <b>6.11.0</b> - 2023-04-28
      </li>
      <li>
        <b>6.11.0-pre.2</b> - 2023-04-27
      </li>
      <li>
        <b>6.11.0-pre.1</b> - 2023-04-26
      </li>
      <li>
        <b>6.11.0-pre.0</b> - 2023-04-26
      </li>
      <li>
        <b>6.10.0</b> - 2023-03-29
      </li>
      <li>
        <b>6.10.0-pre.2</b> - 2023-03-24
      </li>
      <li>
        <b>6.10.0-pre.1</b> - 2023-03-22
      </li>
      <li>
        <b>6.10.0-pre.0</b> - 2023-03-21
      </li>
      <li>
        <b>6.9.0</b> - 2023-03-10
      </li>
      <li>
        <b>6.9.0-pre.0</b> - 2023-03-08
      </li>
      <li>
        <b>6.8.2</b> - 2023-02-27
      </li>
      <li>
        <b>6.8.2-pre.3</b> - 2023-02-23
      </li>
      <li>
        <b>6.8.2-pre.2</b> - 2023-02-22
      </li>
      <li>
        <b>6.8.2-pre.1</b> - 2023-02-22
      </li>
      <li>
        <b>6.8.2-pre.0</b> - 2023-02-21
      </li>
      <li>
        <b>6.8.1</b> - 2023-02-06
      </li>
      <li>
        <b>6.8.1-pre.0</b> - 2023-02-02
      </li>
      <li>
        <b>6.8.0</b> - 2023-01-26
      </li>
      <li>
        <b>6.8.0-pre.1</b> - 2023-01-24
      </li>
      <li>
        <b>6.7.1-pre.0</b> - 2023-01-24
      </li>
      <li>
        <b>6.7.0</b> - 2023-01-18
      </li>
      <li>
        <b>6.7.0-pre.5</b> - 2023-01-18
      </li>
      <li>
        <b>6.7.0-pre.4</b> - 2023-01-17
      </li>
      <li>
        <b>6.7.0-pre.3</b> - 2023-01-13
      </li>
      <li>
        <b>6.7.0-pre.2</b> - 2023-01-13
      </li>
      <li>
        <b>6.7.0-pre.1</b> - 2023-01-11
      </li>
      <li>
        <b>6.6.3-pre.0</b> - 2023-01-11
      </li>
      <li>
        <b>6.6.2</b> - 2023-01-09
      </li>
      <li>
        <b>6.6.2-pre.0</b> - 2023-01-04
      </li>
      <li>
        <b>6.6.1</b> - 2022-12-23
      </li>
      <li>
        <b>6.6.1-pre.1</b> - 2022-12-22
      </li>
      <li>
        <b>6.6.1-pre.0</b> - 2022-12-22
      </li>
      <li>
        <b>6.6.0</b> - 2022-12-21
      </li>
      <li>
        <b>6.6.0-pre.0</b> - 2022-12-16
      </li>
      <li>
        <b>6.5.0</b> - 2022-12-16
      </li>
      <li>
        <b>6.5.0-pre.1</b> - 2022-12-14
      </li>
      <li>
        <b>6.5.0-pre.0</b> - 2022-12-13
      </li>
      <li>
        <b>6.4.5</b> - 2022-12-07
      </li>
      <li>
        <b>6.4.5-pre.2</b> - 2022-12-06
      </li>
      <li>
        <b>6.4.5-pre.1</b> - 2022-12-06
      </li>
      <li>
        <b>6.4.5-pre.0</b> - 2022-12-05
      </li>
      <li>
        <b>6.4.4</b> - 2022-11-30
      </li>
    </ul>
from <a
href="https://snyk.io/redirect/github/remix-run/react-router/releases">react-router-dom
GitHub release notes</a>
  </details>
</details>


<details>
  <summary><b>Commit messages</b></summary>
  </br>
  <details>
    <summary>Package name: <b>react-router-dom</b></summary>
    <ul>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/13fb25a51184f66192e023e2e18be5ff00f37827">13fb25a</a>
chore: Update version for release (near#10866)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/d5b9a18abe0077f5829be05aa2a1abce4611c44c">d5b9a18</a>
Exit prerelease mode</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/6bd6fb9d07e6ef9636659beb6b2660cae2a67529">6bd6fb9</a>
chore: Update version for release (pre) (near#10849)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/37c5f3c610d429439c5d79bf9f789451a1caa024">37c5f3c</a>
chore(router): update generic names (near#10845)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/9b1d1843d27d3bc2c749b99740ff4743af64c88e">9b1d184</a>
chore: Update version for release (pre) (near#10844)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/b6614b0e9452708c0880fef46c52fb0e1805eeaf">b6614b0</a>
Add generics for Remix type enhancements (near#10843)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/3069e526d24514e368640ee7ef7e4557b1b323e2">3069e52</a>
chore: Update version for release (pre) (near#10828)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/2dfc178a255ea58f6d83f63e589d0ecb18e8747c">2dfc178</a>
Enter prerelease mode</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/90289d5f02eb2efc8167faf2a0314f14af0a70fb">90289d5</a>
Update changesets files for Remix v2 release</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/c06984dd09d5d861c745877d80d71088f3afdc5b">c06984d</a>
Merge branch &#x27;main&#x27; into release-next</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/c265a42401d6057e400da2446c9eca45d3c93366">c265a42</a>
Prepare for Remix v2 (near#10715)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/9852bb069e385682f58c0cd8eb6732e3f427a39e">9852bb0</a>
name change (near#10812)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/a4495dee75166546dd92a4072fedab30abce84cf">a4495de</a>
Export proper ErrorResponse type (near#10811)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/4cc8eec22867edae7237e49020595e0be5e06334">4cc8eec</a>
Add some redirect unit tests from Remix (near#10810)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/4b494b935d62cd1244fe5c091db920d3f0315e9e">4b494b9</a>
Update route.lazy docs</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/ae75cdc922485988bb21f5b7b450d787204b0787">ae75cdc</a>
Export ShouldRevalidateFunctionArgs interface (near#10797)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/2208703a3fc77673578d7833774cd4c9e029f2ea">2208703</a>
Add method and URL to aborted query/queryRoute error message
(near#10793)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/496b1fe8253643171ecca6e6a945d98386c4eb00">496b1fe</a>
README&#x27;s fixes (near#10775)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/2709b844a6fcb69820ce47cb8df98376692bace4">2709b84</a>
Fix a race-condition with loader/action-thrown errors on route.lazy
routes (near#10778)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/8b3559a50de61a29972ca161a2fccd007441ac58">8b3559a</a>
Encode URIs during server rendering of &lt;a href&gt;/&lt;form
action&gt; to avoi… (near#10769)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/e11af30e806a3921d4ddc654b29e874a9dd6613c">e11af30</a>
Fix actionResult type on shouldRevalidate args (near#10779)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/e254133b3f1daa9247d1b39ed46f77a7ffba5cdc">e254133</a>
[Docs] Fix typo in &#x60;Navigate&#x60; docs (near#10782)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/6a0875773fb09f651f039522195426b0b9cd8910">6a08757</a>
Organize imports (near#10777)</li>
<li><a
href="https://snyk.io/redirect/github/remix-run/react-router/commit/a0da745ca0379af456f88a19f5abe1d95e101ad4">a0da745</a>
Update examples to latest version</li>
    </ul>

<a
href="https://snyk.io/redirect/github/remix-run/react-router/compare/12e7c2896e5c7cd150e69e8d56d62cc9ed2285dd...13fb25a51184f66192e023e2e18be5ff00f37827">Compare</a>
  </details>
</details>
<hr/>

**Note:** *You are seeing this because you or someone else with access
to this repository has authorized Snyk to open upgrade PRs.*

For more information: <img
src="https://api.segment.io/v1/pixel/track?data=eyJ3cml0ZUtleSI6InJyWmxZcEdHY2RyTHZsb0lYd0dUcVg4WkFRTnNCOUEwIiwiYW5vbnltb3VzSWQiOiIxMDc4MTA3My0zYTMwLTQ5ODAtYTRkZi1jN2MxMDliYWYxNGMiLCJldmVudCI6IlBSIHZpZXdlZCIsInByb3BlcnRpZXMiOnsicHJJZCI6IjEwNzgxMDczLTNhMzAtNDk4MC1hNGRmLWM3YzEwOWJhZjE0YyJ9fQ=="
width="0" height="0"/>

🧐 [View latest project
report](https://app.snyk.io/org/pagoda-pilot/project/12e75fec-70e5-4998-8926-9b5a6351ba5f?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🛠 [Adjust upgrade PR
settings](https://app.snyk.io/org/pagoda-pilot/project/12e75fec-70e5-4998-8926-9b5a6351ba5f/settings/integration?utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr)

🔕 [Ignore this dependency or unsubscribe from future upgrade
PRs](https://app.snyk.io/org/pagoda-pilot/project/12e75fec-70e5-4998-8926-9b5a6351ba5f/settings/integration?pkg&#x3D;react-router-dom&amp;utm_source&#x3D;github&amp;utm_medium&#x3D;referral&amp;page&#x3D;upgrade-pr#auto-dep-upgrades)

<!---
(snyk:metadata:{"prId":"10781073-3a30-4980-a4df-c7c109baf14c","prPublicId":"10781073-3a30-4980-a4df-c7c109baf14c","dependencies":[{"name":"react-router-dom","from":"6.4.4","to":"6.16.0"}],"packageManager":"npm","type":"auto","projectUrl":"https://app.snyk.io/org/pagoda-pilot/project/12e75fec-70e5-4998-8926-9b5a6351ba5f?utm_source=github&utm_medium=referral&page=upgrade-pr","projectPublicId":"12e75fec-70e5-4998-8926-9b5a6351ba5f","env":"prod","prType":"upgrade","vulns":[],"issuesToFix":[],"upgrade":[],"upgradeInfo":{"versionsDiff":68,"publishedDate":"2023-09-13T16:37:49.610Z"},"templateVariants":[],"hasFixes":false,"isMajorUpgrade":false,"isBreakingChange":false,"priorityScoreList":[]})
--->

Co-authored-by: snyk-bot <snyk-bot@snyk.io>
github-merge-queue bot pushed a commit that referenced this issue Mar 25, 2024
Fixes #10769.

## UPD: New motivation

While all said below is true, the main motivation is to account for
nodes impacted at `squash_nodes` which can be touched without much pain
only at `Trie::update`.

## Old motivation

The root cause of errors "node not found" on reads from recorded storage
is that nodes touched only at `Trie::update` - KV updates in the end of
chunk applictaion - were never recorded on memtrie.
It happens automatically on disk tries. For memtries we retroactively
account for trie node accesses, but this wasn't done in similar way for
memtrie updates.
While infrastructure indeed needs to be improved so these issues won't
surprise us anymore, the easiest way is to account for all accesses in
the same way as `move_node_to_mutable` does - on memtrie paths like
`ensure_updated` which move node out of storage to memory, which means
that node has to be recorded, so trie can be validated. Unfortunately
refcount changes are not enough to cover this, so I record trie accesses
separately. Also, memtrie doesn't have access to values, so I have to
retrieve values and record them in the `Trie::update`.

### Testing

* New logic is covered by trie_recording tests. I also discovered an
issue there - `destructively_delete_in_memory_state_from_disk` was
removing all keys because key decoding was incorrect. Now these tests
fully cover trie access scenario: first we have get&get_ref accesses,
and in the very end we have update call for some KV pairs. I confirmed
that for incorrect impl some tests fail because of the same "node not
found" error, and also that new sanity check on `Trie::update` works.
* test_memtrie_discrepancy is renamed and works now

---------

Co-authored-by: Longarithm <the.aleksandr.logunov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants