Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stateless_validation] Refactor all tests to handle ChunkStateWitness and ChunkEndorsement network messages #10508

Closed
shreyan-gupta opened this issue Jan 26, 2024 · 5 comments
Assignees
Labels
A-stateless-validation Area: stateless validation

Comments

@shreyan-gupta
Copy link
Contributor

Handling single client tests with stateless validation is currently very difficult as we don't have good ways to deal with the network messages to send the chunk state witness and chunk endorsements.

As a temporary solution, we're calling process_chunk_endorsement bypassing the network stack for single client settings.

More context in this comment: #10501 (comment)

github-merge-queue bot pushed a commit that referenced this issue Jan 26, 2024
…gle validator tests (#10501)

This is extremely useful in 90% of the test cases that have just one
validator. This way we don't need to explicitly handle network messages
related to `ChunkStateWitness` and `ChunkEndorsement`

Created an issue to fix this in the future:
#10508
@walnut-the-cat
Copy link
Contributor

What's the current status?

@tayfunelmas tayfunelmas added the A-stateless-validation Area: stateless validation label Apr 1, 2024
@walnut-the-cat
Copy link
Contributor

@shreyan-gupta is this needed for MVP?

@tayfunelmas
Copy link
Contributor

Is this still an issue after the new chunk witness distribution work? does the distribution logic has the same shortcoming in tests? I am interested in learning the details of this issue.

@walnut-the-cat
Copy link
Contributor

confirmed with @shreyan-gupta that this is not needed for MVP

@shreyan-gupta
Copy link
Contributor Author

This is actually quite an old issue from Jan. This was for when I had originally implemented the ChunkEndorsement logic for state validation, we didn't have a great way to test out the feature with multiple nodes.

Since then we have invested time in framework like TestLoop to get a set of reliable tests for end to end scenarios. Meanwhile we've also written custom handlers (and tests) for the normal test framework as well. I guess we can close this issue.

@shreyan-gupta shreyan-gupta self-assigned this May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-stateless-validation Area: stateless validation
Projects
None yet
Development

No branches or pull requests

3 participants