Skip to content

Commit

Permalink
ci: move a chunk of the Rust CI over to GHA (#9290)
Browse files Browse the repository at this point in the history
GHA has many significant benefits compared to buildkite, most major of
it is that blindly using GHA is not going to by default allow untrusted
contributors to run arbitrary code – instead GitHub will present
reviewers a button they can click after reviewing the PR.

It also makes maintenance of the CI infrastructure somewhat easier,
which given our soon-to-be-stretched-very-thin infrastructure team is a
huge benefit.

In process of implementing this PR I ended up simplifying a lot of the
Rust testing as well. In particular instead of running half a dozen of
different combinations on just Linux, we now run just the nightly vs
non-nightly versions. This saves CPU time on many different rebuilds… Of
note, one feature that no longer gets tested is `mock_node`, as it was
causing a failure in one of the integration tests. If we wanted to
re-enable this particular test, we should figure out how to fix the
test, rather than adding a new test configuration.

As a final benefit, I’ve also added a m1 macOS-based job. This should
help with making sure that people who develop on company-issued laptops
can actually be productive, rather than have to tip-toe around a
boatload of failing tests. We will have an ability to decide whether we
want to block PRs landing on this job in the repository configuration at
any point in the future.
  • Loading branch information
nagisa authored and nikurt committed Oct 24, 2023
1 parent a8e3d4c commit c36b2bc
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit c36b2bc

Please sign in to comment.