Skip to content

Commit

Permalink
Nayduck - broken tests cleanup (#8403)
Browse files Browse the repository at this point in the history
Taking care of 2 tests (as the goal is to get nayduck to green):
- massive state sync - it depends on the flat storage feature that is being worked on
- chunks recovered from others - the fix is also being worked on
  • Loading branch information
mm-near authored Jan 22, 2023
1 parent c60a7f3 commit 6dcd6d9
Show file tree
Hide file tree
Showing 3 changed files with 20 additions and 16 deletions.
26 changes: 14 additions & 12 deletions integration-tests/src/tests/client/chunks_management.rs
Original file line number Diff line number Diff line change
Expand Up @@ -362,18 +362,20 @@ fn chunks_produced_and_distributed_one_val_per_shard_should_succeed_even_without
/// Note that due to #7385 (which sends chunk forwarding messages irrespective of shard assignment),
/// we disable chunk forwarding messages for the following tests, so we can focus on chunk
/// requesting behavior.
#[test]
#[cfg_attr(not(feature = "expensive_tests"), ignore)]
fn chunks_recovered_from_others() {
Test {
validator_groups: 2,
chunk_only_producers: false,
drop_to_4_from: &["test1"],
drop_all_chunk_forward_msgs: true,
block_timeout: 4 * CHUNK_REQUEST_SWITCH_TO_OTHERS_MS,
}
.run()
}
/// TODO: this test is broken due to (#8395) - with fix in #8211
//#[test]
//#[cfg_attr(not(feature = "expensive_tests"), ignore)]
//fn chunks_recovered_from_others() {
// Test {
// validator_groups: 2,
// chunk_only_producers: false,
// drop_to_4_from: &["test1"],
// drop_all_chunk_forward_msgs: true,
// block_timeout: 4 * CHUNK_REQUEST_SWITCH_TO_OTHERS_MS,
// }
// .run()
//}

/// Same test as above, but the number of validator groups is four, therefore test2 doesn't have the
/// part test4 needs. The only way test4 can recover the part is by reconstructing the whole chunk,
Expand Down
10 changes: 6 additions & 4 deletions nightly/pytest-sanity.txt
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,14 @@ pytest --timeout=600 sanity/state_sync_routed.py manytx 115 --features nightly
#pytest --timeout=300 sanity/state_sync_late.py notx --features nightly

pytest --timeout=3600 sanity/state_sync_massive.py
pytest --timeout=3600 sanity/state_sync_massive.py --features nightly
pytest --timeout=3600 sanity/state_sync_massive_validator.py
pytest --timeout=3600 sanity/state_sync_massive_validator.py --features nightly
pytest sanity/sync_chunks_from_archival.py
pytest sanity/sync_chunks_from_archival.py --features nightly
# TODO(#8322) - re-enable these tests when flat storage starts supporting loading from state dump
# pytest --timeout=3600 sanity/state_sync_massive.py --features nightly
# pytest --timeout=3600 sanity/state_sync_massive_validator.py --features nightly

# TODO(#8211) - tests broken due to bad behavior in chunk fetching - re-enable when that PR is submitted.
# pytest sanity/sync_chunks_from_archival.py
# pytest sanity/sync_chunks_from_archival.py --features nightly
pytest sanity/rpc_tx_forwarding.py
pytest sanity/rpc_tx_forwarding.py --features nightly
pytest --timeout=240 sanity/skip_epoch.py
Expand Down
Empty file modified pytest/tests/sanity/rpc_finality.py
100755 → 100644
Empty file.

0 comments on commit 6dcd6d9

Please sign in to comment.