-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Moved away from tla on testnet #369
base: main
Are you sure you want to change the base?
Conversation
@AlexKushnir1 Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: staleThis pull request was removed from the race, but you can include it again with What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AlexKushnir1 Great job! We are getting very close to solving it once and for all!
@race-of-sloths score 13
workspaces/tests/account.rs
Outdated
let res = worker | ||
.delete_account(sub.id(), sub.signer(), &worker.info().root_id) | ||
.await?; | ||
assert!(res.is_success()); | ||
|
||
let res = worker | ||
.delete_account(account.id(), account.signer(), &worker.info().root_id) | ||
.await?; | ||
assert!(res.is_success()); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Failing tests must clean up the accounts as well to avoid draining the faucet account.
Just for context, the previous comment on this topic was here: https://github.com/near/near-workspaces-rs/pull/369/files#r1713257285, please, either fix the drainage or go back to sandbox.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Returned to the sandbox. The main idea of staying on testnet was that there are no tests on testnet
❌ PR inactiveThis PR has been inactive for two weeks. It's now marked as stale. Tip If you think it's a mistake, you can restart the bot with |
Renamed method (create_tla) and added .testnet to the randomly generated ID sent to the helper when creating a dev account