Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore /lib in git diff #192

Merged
merged 2 commits into from
Aug 25, 2022
Merged

ignore /lib in git diff #192

merged 2 commits into from
Aug 25, 2022

Conversation

volovyks
Copy link
Collaborator

Works both locally and on GitHub

@volovyks volovyks requested a review from ailisp as a code owner August 23, 2022 21:17
ailisp
ailisp approved these changes Aug 25, 2022
View reviewed changes
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Helpful setup! Unrelated to this PR: in ci can we check lib/** is built with the changes in src/

@volovyks
Copy link
Collaborator Author

@ailisp
in NAJ this problem was solved with a hook that is running yarn build before each commit. But it can be annoying because it makes commit process longer.

We should be able to run yarn build on the CI and then check the code with git diff, but we do not have such a setup in any of our libraries.

@volovyks volovyks merged commit 94f39b8 into develop Aug 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailisp ailisp ailisp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volovyks @ailisp