Skip to content
This repository was archived by the owner on Oct 4, 2024. It is now read-only.

fix: update test with create-near-app assumptions #444

Merged
merged 4 commits into from
Jul 6, 2020

Conversation

chadoh
Copy link
Contributor

@chadoh chadoh commented Jul 3, 2020

the structure of create-near-app changed in v1 and we need to change this test to match

the commit that changed it is here: near/create-near-app@7ab9ae3

@chadoh
Copy link
Contributor Author

chadoh commented Jul 3, 2020

@janedegtiareva I think this will fix the test (Travis didn't complete yet when I wrote this)

However, I think it would probably make sense to add create-near-app to this project's devDependencies and use the local version, rather than using the latest version with yarn create. Do you think it makes sense to do that before we merge this one?

the structure of create-near-app changed in v1 and we need to change
this test to match

the commit that changed it is here: near/create-near-app@7ab9ae3
@chadoh chadoh force-pushed the update-create-near-app-test branch from 35f7610 to 74d2f17 Compare July 3, 2020 02:06
near/create-near-app#387 removed the --vanilla flag and made vanilla JS
the default; we can remove this flag here
@janedegtiareva
Copy link
Contributor

I think that the commit that fixes the --vanilla issue is needed too. I think that we also need to file a docs cleanup issue to remove --vanilla from all the things

@janedegtiareva janedegtiareva self-requested a review July 6, 2020 23:55
@janedegtiareva janedegtiareva marked this pull request as ready for review July 6, 2020 23:55
Copy link
Contributor

@janedegtiareva janedegtiareva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to fix the build

@janedegtiareva janedegtiareva merged commit 219416d into master Jul 6, 2020
@chadoh
Copy link
Contributor Author

chadoh commented Jul 7, 2020

Vanilla is not default until near/create-near-app#387 is merged and published

Note that docs changes are already in draft waiting on that one

It needs a review! Please help if you can

I still think having create-near-app unversioned in these tests is a bad idea. Let’s add it to devDependencies so future interface changes don’t break near-shell until dependabot bumps the version

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants