-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(infra): introduce automated publishing #67
Conversation
Kicked auto-merge -- let's fix nits after we make sure the thing works as intended. |
Unversioning everything to have all of this happen in a separate PR? I'm a little confused about why this is necessary |
@austinabell, unversioning everything in the source code because now all crates share the version in the root Cargo.toml. The version only needs to be updated in one place in a PR and CI fills it in at the time of publish for all the member crates. |
Hm, yeah, looking around it seems that, eg, serde is doing releases https://github.com/serde-rs/serde/releases, so this is a strong evidence that I am wrong, and that folks do actually find them useful. Than, yeah, we should add "create gh release" to the automation. |
I have resolved the Travis issue (it was explicitly set in the branch protection rule on github to wait for Travis checks) @miraclx Please, merge once you feel ready, the PR is unblocked |
Great. I still have some unpushed commits (creating release works, but I'm touching on it a bit so it's WIP). I'll update on the status in a sec. |
629055e
to
4e7428c
Compare
This looks good to me now. @frol, @matklad, @austinabell please take a second look. |
bdf77d7
to
01a730a
Compare
Glad to announce: the release passed successfully. Release Page: https://github.com/near/borsh-rs/releases/tag/v0.9.2
Now we just need to make sure the CHANGELOG stays updated before each new release. |
This PR introduces a CI job that automates versioning and publishing borsh-rs crates to crates.io.
Here's what the tag page should look like:
Here's what the release page should look like: