Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix clippy warnings #47

Merged
merged 1 commit into from
Dec 1, 2021
Merged

chore: fix clippy warnings #47

merged 1 commit into from
Dec 1, 2021

Conversation

hrls
Copy link
Contributor

@hrls hrls commented Nov 30, 2021

No description provided.

matklad
matklad reviewed Nov 30, 2021
View reviewed changes
Copy link
Contributor

@matklad matklad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Don't have strong opinion here:

  • on the one hand, none of the changes make the code meaningfully better
  • on the other hand, clippy helps with consitency for projects which don't have a super strict code owner.

frol
frol approved these changes Dec 1, 2021
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contributions! I love clippy and its help to keep the code nice and clean. Special thanks for adding the check to the CI

@frol frol merged commit b03a03c into near:master Dec 1, 2021
@hrls hrls deleted the chore/fix-clippy branch December 1, 2021 22:22
This was referenced Dec 21, 2021
Closed
Closed
This was referenced May 31, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matklad matklad matklad left review comments

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hrls @frol @matklad