chore: fully qualify #cratename::BorshSchema in derive
#244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
commented
Oct 12, 2023
Comment on lines
+41
to
+49
|
|
||
| // https://github.com/near/borsh-rs/issues/112 | ||
| #[allow(unused)] | ||
| impl A { | ||
| pub fn declaration() -> usize { | ||
| 42 | ||
| } | ||
| } | ||
| assert_eq!("A".to_string(), <A as borsh::BorshSchema>::declaration()); |
There was a problem hiding this comment.
this change on current master results in compilation error
1 error[E0277]: the trait bound `String: Borrow<usize>` is not satisfied
--> borsh/tests/test_schema_structs.rs:39:14
|
39 | #[derive(borsh::BorshSchema)]
| ^^^^^^^^^^^^^^^^^^ the trait `Borrow<usize>` is not implemented for `String`
|
= help: the trait `Borrow<str>` is implemented for `String`
note: required by a bound in `BTreeMap::<K, V, A>::get`
--> /home/user/.rustup/toolchains/stable-x86_64-unknown-linux-gnu/lib/rustlib/src/rust/library
/alloc/src/collections/btree/map.rs:696:12
|
694 | pub fn get<Q: ?Sized>(&self, key: &Q) -> Option<&V>
| --- required by a bound in this associated function
695 | where
696 | K: Borrow<Q> + Ord,
| ^^^^^^^^^ required by this bound in `BTreeMap::<K, V, A>::get`
= note: this error originates in the derive macro `borsh::BorshSchema` (in Nightly builds, run with
-Z macro-backtrace for more info)
frol
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #112 ,
which either was not fully resolved by #140 or reemerged later in the process
this is not a breaking change and can be safely included in 1.0.1 release