chore: simplify discriminants handling in schema derives #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dj8yfo
reviewed
Oct 6, 2023
borsh-derive/src/internals/schema/enums/snapshots/borsh_discriminant_true.snap
Show resolved
Hide resolved
There’s no need for a separate discriminant variable and assignment statement in the derived code. The value of the discriminant can be included directly in the entry for the variant.
|
cargo-doc failure is not of my doing. |
dj8yfo
changed the title
dj8yfo
reviewed
Oct 24, 2023
| @@ -139,21 +125,21 @@ fn process_variant( | |||
| inner_struct_definition(variant, cratename, &full_variant_ident, enum_generics); | |||
| let (_ig, inner_struct_ty_generics, _wc) = inner_struct_generics.split_for_impl(); | |||
|
|
|||
| let add_definitions_recursively_call = quote! { | |||
| <#full_variant_ident #inner_struct_ty_generics as #cratename::BorshSchema>::add_definitions_recursively(definitions); | |||
| let variant_type = quote! { | |||
There was a problem hiding this comment.
a better name for variable might be fully_qualified_variant_type
dj8yfo
reviewed
Oct 24, 2023
| let definition = borsh::schema::Definition::Enum { | ||
| tag_width: 1, | ||
| variants: borsh::__private::maybestd::vec
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There’s no need for a separate discriminant variable and assignment
statement in the derived code. The value of the discriminant can be
included directly in the entry for the variant.