Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore!: rename "Array<T0, N>" -> "[T0; N]" (schema::Declaration) #235

Merged
merged 2 commits into from
Sep 26, 2023
Merged

chore!: rename "Array<T0, N>" -> "[T0; N]" (schema::Declaration) #235

merged 2 commits into from
Sep 26, 2023

Conversation

dj8yfo
Copy link
Collaborator

@dj8yfo dj8yfo commented Sep 26, 2023 •
edited
Loading

part of #231 resolution

@dj8yfo dj8yfo marked this pull request as ready for review September 26, 2023 13:46
@dj8yfo dj8yfo requested a review from frol as a code owner September 26, 2023 13:46
frol
frol approved these changes Sep 26, 2023
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a strong opinion here, so I am fine with the proposed changes to the Schema.

@dj8yfo dj8yfo merged commit 7afe64a into master Sep 26, 2023
7 checks passed
@dj8yfo dj8yfo deleted the rename_declarations_arrays branch September 26, 2023 17:24
@frol frol mentioned this pull request Sep 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dj8yfo @frol