chore!: rename "Tuple<T0, T1, T2...>" -> "(T0, T1, T2...)" (schema::Declaration)
#234
Conversation
| if params.len() == 1 { | ||
| format!(r#"({},)"#, params[0]) | ||
| } else { | ||
| format!(r#"({})"#, params.join(", ")) | ||
| } |
There was a problem hiding this comment.
Do we really need it? I mean, in Rust and Python tuples require to have this comma to disambiguate from just grouping expressions with parenthesis (2+2)*2, but I don't see a reason to have it here. Do I miss something?
There was a problem hiding this comment.
This comma looks really jarring, and it may cause one to reconsider using the type of first element directly instead of one-element tuple).
Having it exactly the same as in rust has a benefit of possibility to parse it with syn, though parsing shouldn't be needed at all, as the same info is available via schema::Definition.
the change was primarily to help visually distinguish declarations of tuples from what would be derived for a generic struct named Tuple<T0, T1,...>
…ma::Declaration`)
dj8yfo
force-pushed
the
rename_declarations_tuples
branch
from
3ea4358
to
219419c
Compare
part of #231 resolution