feat!: add Definition::Sequence::length_range field
#220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mina86 you want this or Sequence { // replaces `Array` and supports varint
length_width: u8,
min_length: u64,
max_length: u64,
elements: Declaration,
}, |
|
I’m gonig to add length_width and replace Array in next PR. |
dj8yfo
requested changes
Sep 14, 2023
Having a length_range field in the Sequence definition allows to better specify encoding formats for bounded vectors. This in turn helps with performing calculations such as figuring out the maximum or minimum length of encoding of a type.
dj8yfo
changed the title
Definition::Sequence::length_range field
dj8yfo
approved these changes
Sep 19, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Having a length_range field in the Sequence definition allows to
better specify encoding formats for bounded vectors. This in turn
helps with performing calculations such as figuring out the maximum or
minimum length of encoding of a type.