-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore!: PartialOrd
-> Ord
bound for hashcollections
#203
Conversation
dd7285f
to
d5ac0a5
Compare
PartialOrd
-> Ord
bound for hashcollectionsPartialOrd
-> Ord
bound for hashcollections
@matklad The reasoning for that @dj8yfo What do you think? |
Sorry for being confusing, what I meant is:
not
|
d5ac0a5
to
13a9bb5
Compare
Removed commit with making |
PartialOrd
-> Ord
bound for hashcollectionsPartialOrd
-> Ord
bound for hashcollections
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot think of how we could handle non-Ord types in collections, so I believe it is a good move, but let's see how it turns out when we upgrade nearcore / near-sdk-rs.
13a9bb5
to
4ef4947
Compare
So far i've only noticed this example, affected by this |
This pr is part of #51 resolution.
It addresses the following comments of review:
Second comment is addressed by second commit: feat!: raise bound on keys in hashcollections PartialOrd -> Ord.
Code with
f32
andf64
won't be affected by this breaking change, asf32
andf64
aren'tEq
, so it's not possible to constructHashSet
orHashMap
with these types as keys in the first place (insert
in both collections requireEq
bound).