-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add top-level from_slice #142
Conversation
@iho Thanks for the contribution! There are just a couple of review comments to address and we are good to merge this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are almost there. Just a couple of small discussions to solve and ready to merge.
re-openning PR to trigger CI (I don't know what happened) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iho Great job! Merging it now
Addresses several items from #51:
BorshDeserialize::try_from_slice
in favor ofborsh::from_slice
top-level function ( 😡 a lot of churn with this one)