fix: codegen sanity for enum serialization #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matklad
approved these changes
Aug 16, 2022
| @@ -77,7 +77,7 @@ pub fn enum_de(input: &ItemEnum, cratename: Ident) -> syn::Result<TokenStream2> | |||
| if let Some(method_ident) = init_method { | |||
| Ok(quote! { | |||
| impl #impl_generics #cratename::de::BorshDeserialize for #name #ty_generics #where_clause { | |||
| fn deserialize(buf: &mut &[u8]) -> core::result::Result<Self, #cratename::maybestd::io::Error> { | |||
| fn deserialize(buf: &mut &[u8]) -> ::core::result::Result<Self, #cratename::maybestd::io::Error> { | |||
There was a problem hiding this comment.
Ideally, we'd use a name from borsh crate here, like serde does, but ::core is already an improvement:
There was a problem hiding this comment.
And that would keep sanity for if you imported a crate named core? That one feels more opinionated since it increases the exposed __private API so maybe best to do it in a separate PR?
There was a problem hiding this comment.
That's definitely should be done in a separate PR, if at all.
Practically, I wouldn't expect this to make any difference, but it's just good hygiene (pun intended) to only rely on names provided by the runtime-support crate and not rely on any properties of the call-site environment.
frol
approved these changes
Sep 30, 2022
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
structs were fixed in 985a20b but this was not done for enums.
cc @BenKurrek