Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lostcancel #20

Merged
merged 2 commits into from
Dec 25, 2024
Merged

Fix lostcancel #20

merged 2 commits into from
Dec 25, 2024

Conversation

ne-sachirou
Copy link
Owner

  Error: graceful.go:61:2: lostcancel: the cancel function is not used on all paths (possible context leak) (govet)
  	ctx, cancel := context.WithCancelCause(ctx)
  	^
  Error: graceful.go:75:3: lostcancel: this return statement may be reached without using the cancel var defined on line 61 (govet)
  		return errors.Join(errors.New("failed to start servers"), err)
  		^

@ne-sachirou ne-sachirou self-assigned this Dec 25, 2024
@ne-sachirou ne-sachirou marked this pull request as draft December 25, 2024 11:39
@ne-sachirou ne-sachirou marked this pull request as ready for review December 25, 2024 11:44
@ne-sachirou ne-sachirou merged commit f1f8ccf into main Dec 25, 2024
4 checks passed
@ne-sachirou ne-sachirou deleted the fix-lostcancel branch December 25, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant