Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2024.5.0 #80

Merged
merged 31 commits into from
Dec 18, 2024
Merged

Release 2024.5.0 #80

merged 31 commits into from
Dec 18, 2024

Conversation

josephbirkner
Copy link
Contributor

@josephbirkner josephbirkner commented Oct 23, 2024

Closes #63

@josephbirkner josephbirkner changed the title Add validity header Advanced Validity Encoding Oct 23, 2024
@josephbirkner josephbirkner marked this pull request as ready for review November 4, 2024 08:09
@josephbirkner
Copy link
Contributor Author

josephbirkner commented Nov 5, 2024

  • Python bindings (add to issue)
  • Docs
  • Adjust erdblick so it can process/visualize the new validities.

@josephbirkner josephbirkner changed the title Advanced Validity Encoding Release 2024.5.0 Nov 11, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Waguramu and others added 19 commits December 9, 2024 14:36
* Enhanced Validity class with geometry offset and description types.
* Added new methods in Validity for managing offset points, ranges, and simple geometry.
* Updated StringPool with new static keys for geometry-related attributes.
* Adjusted serialization logic for Validity data.
… clarity and consistency.

* Add methods in TileFeatureLayer to create and resolve Validity and ValidityCollection objects.
* Update Validity to support ValidityCollection handling with initial capacity setting.
* Adjust serialization and data management to include validities in the model structure.
* Enhance cloning and resolution in TileFeatureLayer to handle validity structures and collections.
…in meters.

* Enhance Validity with computeGeometry method for handling geometries based on validity's geometryName.
* Refactor and improve validity handling logic in TileFeatureLayer::clone.
* Integrate error handling and extend geometry processing in computeGeometry.
* Introduce helper functions projectPointOnLine and calcLineLengthInM for geometry processing.
* Update geometryFromPositionBound and geometryFromLengthBound methods for detailed geometry manipulation.
…ty, renamed const accessors to xOrNull, renamed AbsoluteLengthOffset to MetricLengthOffset.
@@ -34,11 +34,14 @@ struct QualifiedSourceDataReference {
/**
* Proxy node that represents an array of Qualifier-String + SourceDataReference tuples:
* SourceDataAddressNode.
*
* 8b column id
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbr

Copy link

Package Line Rate Branch Rate Health
libs.http-datasource.src 57% 31%
libs.http-service.src 61% 34%
libs.logging.include.mapget 71% 33%
libs.model.include.mapget.model 54% 36%
libs.model.src 63% 35%
libs.service.include.mapget.service 67% 0%
libs.service.src 75% 43%
Summary 64% (3408 / 5340) 36% (3298 / 9175)

Minimum allowed line rate is 50%

Copy link
Contributor

@Waguramu Waguramu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@Waguramu Waguramu merged commit 0109f9f into main Dec 18, 2024
15 checks passed
@Waguramu Waguramu deleted the attribute-validities branch December 18, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Advanced attribute/relation validities
3 participants