Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch NiceCXNetwork.upload_to() to named parameters and add client parameter #80

Closed
coleslaw481 opened this issue Apr 28, 2021 · 1 comment
Closed

Switch NiceCXNetwork.upload_to() to named parameters and add client parameter #80

coleslaw481 opened this issue Apr 28, 2021 · 1 comment
Assignees
@coleslaw481
Labels
enhancement
Milestone
3.4.0

Comments

@coleslaw481
Copy link
Contributor

NiceCXNetwork.upload_to() should use named parameters cause there are cases where the server, username, and password should be set to None. Also add a client parameter that lets one set the Ndex2 client to use instead of creating one internally.

Finally add a deprecation notice for the server, username, password, user_agent parameters
@coleslaw481 coleslaw481 self-assigned this Apr 28, 2021
@coleslaw481 coleslaw481 added this to the 3.4.0 milestone Apr 30, 2021
coleslaw481 added a commit that referenced this issue May 1, 2021
@coleslaw481
switched update_to() and upload_to() to use named parameters and adde…
2cd781f 
…d client named parameter. Fix for issues #80 and #81
@coleslaw481
Copy link
Contributor Author

Fixed in branch3.4.0

coleslaw481 added a commit that referenced this issue May 1, 2021
@coleslaw481
added notes about fixes for issues #80 and #81
954175b
coleslaw481 added a commit that referenced this issue May 3, 2021
@coleslaw481
Added offset/limit parameters to Ndex2.get_network_ids_for_user() #78,…
99098c4 
… switched NiceCXNetwork.upload_to() and NiceCXNetwork.update_to() to named args and added client parameter #80 and #81, Fixed documentation in NiceCXNetwork.update_to() to denote return value #82, Added Ndex2.get_user_by_id(), Added Ndex2.get_id_for_user(), Added Ndex2.get_networksets_for_user_id() #61
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@coleslaw481 coleslaw481

Labels
enhancement
Projects
None yet
Milestone
3.4.0
Development

No branches or pull requests
1 participant
@coleslaw481