Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log folder created in installation folder #26

Closed
bgyori opened this issue Dec 4, 2018 · 4 comments
Closed

Log folder created in installation folder #26

bgyori opened this issue Dec 4, 2018 · 4 comments
Milestone

Comments

@bgyori
Copy link
Contributor

bgyori commented Dec 4, 2018

The code here: https://github.com/ndexbio/ndex2-client/blob/master/ndex2/__init__.py#L19-L23
attempts to make a logs directory within the package folder. This doesn't work if the package is installed in a folder (e.g. with sudo pip install) for which the user doesn't normally have write permission. This led me to a situation where I can't import the package due to the folder creation erroring. Is there some way to change this behavior?

@bgyori
Copy link
Contributor Author

bgyori commented Dec 4, 2018

Looks like there is a relevant commit (7a0e671) which might solve this, my error was with the version on PyPI which hasn't been released since.

@coleslaw481
Copy link
Contributor

Hi,
Yes I ran into the same issue and have committed a fix. I'll cut a release as soon as I can.

thanks,

chris

@coleslaw481
Copy link
Contributor

Pushed a release candidate 2.0.1rc4 to PyPI. After a bit more testing will do a formal release.

@coleslaw481 coleslaw481 added this to the 2.0.1 milestone Jan 3, 2019
@coleslaw481
Copy link
Contributor

2.0.1 has been released with fix to PyPI. Closing ticket, please reopen if there is still an issue.

I noticed there is an ndex2-dev and ndex2-performance repo that are almost identical to the ndex2 repo. Going to probably deprecate these repos since they are confusing. If a release of this fix to those repos is needed please let me know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants