Updated test for when long int is not 8 byte #132
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If sizeof(long int) != 8, the current tests will fail. Update the test to use limits.h to help know what LONG_MAX/MIN are. This also implies that iniparser_getlongint() will vary in terms of being able to accept different width integers, depending on architecture. The goal here was to fix the test, not change the API.
dbungert
force-pushed
the
32bit-long-int
branch
from
e3eb56c to
ef9975d
Compare
|
This has been addressed in #140 |
|
Fixed in #140 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If sizeof(long int) != 8, the current tests will fail. Update the test
to use limits.h to help know what LONG_MAX/MIN are.
This also implies that iniparser_getlongint() will vary in terms of
being able to accept different width integers, depending on
architecture. The goal here was to fix the test, not change the API.