Cast characters to unsigned char before passed to isspace() #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reason: The c argument is an int, the value of which the application shall ensure is a character representable as an unsigned char or equal to the value of the macro EOF. If the argument has any other value, the behavior is undefined. http://man7.org/linux/man-pages/man3/isspace.3p.html
|
This fix is required to use non-ASCII charsets (ex. UTF-8) |
|
Can you add a test case? |
|
Sorry, but I cannot see why this should be required to support non-ASCII charsets. I cannot reproduce these issues. I added commit ab196cb to Test UTF-8 and dots in keys and the test passed. For now I will close this pull request. If this is a Windows issue, please help us to get the test build and run on our Windows runner so we can reproduce it. Then this pull request may be re-considered. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This would avoid sign extension.
Reason: The c argument is an int, the value of which the application
shall ensure is a character representable as an unsigned char or equal
to the value of the macro EOF. If the argument has any other value,
the behavior is undefined.
[man7.org] (http://man7.org/linux/man-pages/man3/isspace.3p.html)