Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

passcode is encoded via "htmlspecialchars" function Closes #636 #637

Merged
merged 1 commit into from
Feb 6, 2025

Conversation

FrancescoTerrosi
Copy link
Contributor

@FrancescoTerrosi FrancescoTerrosi commented Jan 31, 2025

This bugfix Closes #636 by encoding html special characters to display the correct passcode for recordings, in the unlucky case the passcode generated by zoom contains a sequence of characters that may be misinterpreted as html characters

@FrancescoTerrosi FrancescoTerrosi changed the title passcode is encoded via "htmlspecialchars" function closes passcode is encoded via "htmlspecialchars" function closes#636 Jan 31, 2025
@FrancescoTerrosi FrancescoTerrosi changed the title passcode is encoded via "htmlspecialchars" function closes#636 passcode is encoded via "htmlspecialchars" function Closes #636 Jan 31, 2025
@jrchamp jrchamp added the bug Fixes problems or reduces technical debt label Feb 6, 2025
Copy link
Collaborator

@jrchamp jrchamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thank you for identifying and fixing this issue. 🥂

@jrchamp jrchamp merged commit e1b6f75 into ncstate-delta:main Feb 6, 2025
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes problems or reduces technical debt
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Recording's passcode display bug
2 participants