Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vegplot Transect: Add support for Transect Ground Surface Cover #373

Merged
merged 10 commits into from
Mar 1, 2025

Conversation

brownag
Copy link
Member

@brownag brownag commented Feb 22, 2025

Add get_vegplot_groundsurface_from_NASIS_db() and get_vegplot_transplantfoliar_from_NASIS_db() from @phytoclast

Following from discussion in the FPAC-NRCS R User Group Teams channel.

  • I have tentatively added get_vegplot_BA_snags_from_NASIS_db() but I think it could potentially be combined with existing functions
  • Documentation could be cleaned up and made more consistent across all vegplot vegetation data functions
  • si argument for converting units could be implemented for other pre-existing functions and columns See Vegetation Data: unit conversion for above-ground measurements #374

@brownag
Copy link
Member Author

brownag commented Feb 24, 2025

Confirmed the existing query in get_vegplot_from_NASIS_db() already includes siteiid, siteobsiid, vegplotid, vegplotname, overstorycancontotalpct, basalareaplottotal, treesnagdensityhard, treesnagdensitysoft which are all 1:1 with vegplot table, so get_vegplot_BA_snags_from_NASIS_db() can safely be omitted from this PR

@brownag
Copy link
Member Author

brownag commented Feb 24, 2025

Also get_vegplot_transpecies_from_NASIS_db() already covers the data elements returned by get_vegplot_transplantfoliar_from_NASIS_db().

The unit conversion portion would be valuable to incorporate--need to look at all the columns that need SI unit conversions to handle it more generally.

@brownag brownag changed the title Vegplot Transect: Add support for Ground Surface and Plant Foliar Cover Vegplot Transect: Add support for Transect Ground Surface Cover Feb 24, 2025
@brownag brownag marked this pull request as ready for review February 26, 2025 16:28
- use ncss-tech r-universe repo
- use soilDBdata from ncss-tech.r-universe.dev
@brownag
Copy link
Member Author

brownag commented Mar 1, 2025

get_vegplot_groundsurface_from_NASIS_db() has been added to the vegplot data returned by fetchVegdata() and tested for basic functionality via the soilDBdata snapshot

@brownag brownag merged commit 3684b3e into master Mar 1, 2025
5 checks passed
@brownag brownag deleted the vegtransect-groundsurface branch March 1, 2025 00:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant