Remove {scales} from Suggests #288
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we need {scales} in suggests for examples that use
aqp::plotSPC()In this PR ncss-tech/aqp#280 I addressed several issues related to suggested aqp packages. For scales, an optional branch in the code was added to plotSPC() such that when the scales namespace is not available a base R alternate is used. I believe this alternate is a complete replacement for the scales usage in plotSPC(), but it has not been extensively tested outside our standard CI.
When aqp 2.0 is released we can likely safely drop the {scales} dependency in soilDB. No code in soilDB package uses scales, but it is required to conditionally allows examples to run (preventing error from
plotSPC()when scales is not available)