fetchNASIS("components"): use duplicates argument and custom profile ID for many:1 relationships of legend, mapunit to datamapunit
#251
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… mapunit and datamapunit
brownag
referenced
this pull request
Jun 11, 2022
|
Good idea, I've always been annoyed with the previous approach. I'll do some testing when I get back. |
- fix join of site data, diagnostics and restrictions - add mukey (alias of lmapunitiid) to `get_component_correlation_data_from_NASIS_db()`
brownag
changed the title
duplicates argument and custom profile ID for many:1 relationships of legend, mapunit to datamapunit
|
This works as it should, and does not change historic default behavior. Slight breaking change from 2.7.1 in that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many mapunits. Uses
get_component_correlation_data_from_NASIS_db(), providesdropAdditionaldropNonRepresentativeandduplicatesas optional arguments tofetchNASIS(). Creates a non-standard "coiidcmb" from the combination oflmapunitiid:muiid:dmuiid:coiidwhich is used as the result SPC ID column.This seems to now be working as I intended after checking to make sure all joins have an appropriate ID on left and right hand side.