Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_hz_logic overhaul #65

Closed
dylanbeaudette opened this issue Dec 12, 2018 · 1 comment
Closed

test_hz_logic overhaul #65

dylanbeaudette opened this issue Dec 12, 2018 · 1 comment

Comments

@dylanbeaudette
Copy link
Member

This function needs a total re-write. It is an important component in soilDB::fetchNASIS().

  • this checking assumes that the data are sorted!
  • give a reason for failing
  • perform checks and then report matrix of pass/failure
brownag added a commit that referenced this issue Jan 22, 2020
@brownag
make .hzTests() -- simpler accessor method to key 'logic' of checkHzD…
8e508c2 
…epthLogic() #65
@brownag
Copy link
Member

brownag commented Jul 6, 2020

You addressed this issue a while back. test_hz_logic is deprecated and replaced with of hzDepthTests and checkHzDepthLogic. Recently, spc_in_sync (may be re-named) was added to determine collection level validity in a similar format to the horizon functions.

@brownag brownag closed this as completed Jul 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanbeaudette @brownag