integrity check should not rely on metadata, in case metadata are cor…

…rupt/missing #137
ncss-tech · Jul 8, 2020 · 53c13df · 53c13df
1 parent 9802e7e
commit 53c13df
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/R/SoilProfileCollection-integrity.R b/R/SoilProfileCollection-integrity.R
@@ -72,8 +72,7 @@ spc_in_sync <- function(object) {
   two <- ifelse(one, all(sid == cohid), FALSE)
 
   # check 3: horizon IDs are in order of profile ID in site
-  #          and, within profiles, have correct top-depth sequence
-  three <- all(cohzid[metadata(object)$target.order] == cohzid)
+  three <- all(.coalesce.idx(match(hid, sid)) == 1:length(sid))
 
   return(data.frame(siteDepth = one,
                     relativeOrder = two,