Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add view-transition as allowed name for meta-tag. #225

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Add view-transition as allowed name for meta-tag. #225

merged 1 commit into from
Oct 23, 2023

Conversation

jablonski
Copy link
Contributor

@jablonski jablonski commented Oct 23, 2023

It's quite new, but helps a lot to showcase MPAs with smooth transitions.

https://daverupert.com/2023/05/getting-started-view-transitions/

Current workaround is to use a template literal:

{<meta name="view-transition" content="same-origin" />}

It's quite new, but helps a lot to showcase MPAs with smooth transitions.

https://daverupert.com/2023/05/getting-started-view-transitions/

Current workaround is to use a template literal:

{`<meta name="view-transition" content="same-origin" />`}
@ncpa0cpl ncpa0cpl merged commit e7d21b4 into ncpa0:master Oct 23, 2023
3 checks passed
@ncpa0cpl
Copy link
Collaborator

ncpa0cpl commented Oct 23, 2023

hey @jablonski if you ever submit another PR I'd like to ask you to add a prefix in the commit like fix: or feat:, I am following the Conventional Commit spec, so this would save me the trouble of amending the commits after merge

@jablonski
Copy link
Contributor Author

Sorry, will not happen again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants