Merge pull request cms-sw#152 from ktf/use-yaml-for-watcher

Move all watchers to be in the yaml file.

process-pull-request

@@ -5,7 +5,6 @@ from optparse import OptionParser
 from categories import CMSSW_CATEGORIES, CMSSW_L2, CMSSW_L1
 from releases import RELEASE_BRANCH_MILESTONE, RELEASE_BRANCH_PRODUCTION, RELEASE_BRANCH_CLOSED
 from releases import RELEASE_MANAGERS
-from watchers import WATCHERS
 import yaml
 
 import re
@@ -76,7 +75,7 @@ if __name__ == "__main__":
     signing_categories.add("new-package")
 
   # Add watchers.yaml information to the WATCHERS dict.
-  WATCHERS.update(yaml.load(file("watchers.yaml")))
+  WATCHERS = (yaml.load(file("watchers.yaml")))
   # Given the packages check if there are additional developers watching one or more.
   author = pr.user.login
   watchers = set([user for package in packages

tests/test_watchers.py

@@ -1,4 +1,19 @@
 #!/usr/bin/env python
 
-from watchers import *
 from releases import *
+import yaml
+import re
+# Validate the schema of watchers.
+
+KEY_RE = "[^@]+"
+VALUE_RE = "[A-Za-z0-0.*+]"
+
+w = yaml.load(open("watchers.yaml", "r"))
+assert(type(w) == dict)
+for (key, value) in w.items():
+  assert(type(key) == str)
+  assert(re.match(KEY_RE, key))
+  assert(type(value) == list)
+  for x in value:
+    assert(type(x) == str)
+    assert(re.match(VALUE_RE, x))