Throw explicit error if list releases reponse doesn't have data

ncipollo · Jan 12, 2025 · 033b82b · 033b82b
1 parent e774b3e
commit 033b82b
Show file tree

Hide file tree

Showing 4 changed files with 35 additions and 2 deletions.
diff --git a/__tests__/Action.test.ts b/__tests__/Action.test.ts
@@ -218,6 +218,32 @@ describe("Action", () => {
 
     })
 
+    it('throws error when list has no data', async () => {
+
+        const action = createAction(true, true)
+        getMock.mockRejectedValue({status: 404})
+        const error = {
+            errors: [
+                {
+                    code: 'already_exists'
+                }
+            ]
+        }
+
+        createMock.mockRejectedValue(error)
+        listMock.mockResolvedValue({})
+        expect.hasAssertions()
+        try {
+            await action.perform()
+        } catch (error) {
+            expect(error).toEqual(Error("No releases found. Response: {}"))
+        }
+
+        expect(listMock).toBeCalled()
+        expect(createMock).not.toBeCalled()
+        expect(updateMock).not.toBeCalled()
+    })
+
     it('throws error when update fails', async () => {
         const action = createAction(true, true)
 
@@ -428,7 +454,7 @@ describe("Action", () => {
                 destroyArtifacts: artifactDestroyMock
             }
         })
-        
+
         const MockActionSkipper = jest.fn<ActionSkipper, any>(() => {
             return {
                 shouldSkip: shouldSkipMock

diff --git a/dist/index.js b/dist/index.js
@@ -124,6 +124,9 @@ class Action {
         const tag = this.inputs.tag;
         const response = await this.releases.listReleases();
         const releases = response.data;
+        if (!releases) {
+            throw new Error(`No releases found. Response: ${JSON.stringify(response)}`);
+        }
         const draftRelease = releases.find(release => release.draft && release.tag_name == tag);
         return draftRelease?.id;
     }

diff --git a/dist/index.js.map b/dist/index.js.map
diff --git a/src/Action.ts b/src/Action.ts
@@ -120,6 +120,10 @@ export class Action {
         const tag = this.inputs.tag
         const response = await this.releases.listReleases()
         const releases = response.data
+        if(!releases) {
+            throw new Error(`No releases found. Response: ${JSON.stringify(response)}`)
+        }
+
         const draftRelease = releases.find(release => release.draft && release.tag_name == tag)
 
         return draftRelease?.id