feat: #12 add eslint for unit-tests

ncats · Aug 17, 2021 · 9e01e6f · 9e01e6f
1 parent 40f047a
commit 9e01e6f
Show file tree

Hide file tree

Showing 29 changed files with 687 additions and 669 deletions.
diff --git a/.eslintrc b/.eslintrc
@@ -1,7 +1,10 @@
 {
     "parser": "@typescript-eslint/parser",
     "parserOptions": {
-        "project": "./tsconfig.json"
+        "project": [
+            "./tsconfig.json",
+            "./test/unit/tsconfig.json"
+        ]
     },
     "plugins": [
         "@typescript-eslint",

diff --git a/package.json b/package.json
@@ -25,8 +25,7 @@
     "start": "tsdx watch",
     "build": "tsdx build",
     "test": "tsdx test",
-    "lint": "eslint ./src/**/*.ts",
-    "lint:fix": "eslint ./src/**/*.ts --fix",
+    "lint": "eslint ./src/**/*.ts ./test/unit/**/*.ts",
     "sample": "concurrently --kill-others \"npm run parcel\" \"npm run server\"",
     "parcel": "parcel serve ./samples/Parcel/src/index.html --no-cache",
     "server": "node ./samples/Parcel/server.js"

diff --git a/src/SigninRequest.ts b/src/SigninRequest.ts
@@ -6,7 +6,7 @@ import { SigninState } from "./SigninState";
 
 export class SigninRequest {
     public readonly url: string;
-    public readonly state: any;
+    public readonly state: SigninState;
 
     constructor({
         // mandatory

diff --git a/src/State.ts b/src/State.ts
@@ -5,7 +5,7 @@ import { Log, random } from "./utils";
 import { StateStore } from "./StateStore";
 
 export class State {
-    public readonly id: any;
+    public readonly id: string;
     public readonly data: any;
     public readonly created: number;
     public readonly request_type: any;

diff --git a/test/unit/AccessTokenEvents.test.ts b/test/unit/AccessTokenEvents.test.ts
@@ -1,9 +1,9 @@
 // Copyright (c) Brock Allen & Dominick Baier. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
 
-import { Timer } from '../../src/utils';
-import { AccessTokenEvents } from '../../src/AccessTokenEvents';
-import { User } from '../../src/User';
+import { Timer } from "../../src/utils";
+import { AccessTokenEvents } from "../../src/AccessTokenEvents";
+import { User } from "../../src/User";
 
 describe("AccessTokenEvents", () => {
 
@@ -22,8 +22,7 @@ describe("AccessTokenEvents", () => {
     describe("constructor", () => {
 
         it("should use default expiringNotificationTime", () => {
-            // @ts-ignore
-            expect(subject._accessTokenExpiringNotificationTime).toEqual(60);
+            expect(subject["_accessTokenExpiringNotificationTime"]).toEqual(60);
         });
 
     });
@@ -125,7 +124,7 @@ class StubTimer extends Timer {
     duration: any;
 
     constructor(name: string) {
-        super(name)
+        super(name);
         this.cancelWasCalled = false;
     }
 
@@ -137,6 +136,8 @@ class StubTimer extends Timer {
         this.cancelWasCalled = true;
     }
 
+    // eslint-disable-next-line @typescript-eslint/no-empty-function
     addHandler() {}
+    // eslint-disable-next-line @typescript-eslint/no-empty-function
     removeHandler() {}
 }
diff --git a/test/unit/ErrorResponse.test.ts b/test/unit/ErrorResponse.test.ts
@@ -1,7 +1,7 @@
 // Copyright (c) Brock Allen & Dominick Baier. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
 
-import { ErrorResponse } from '../../src/ErrorResponse';
+import { ErrorResponse } from "../../src/ErrorResponse";
 
 describe("ErrorResponse", () => {
 
@@ -22,31 +22,31 @@ describe("ErrorResponse", () => {
 
         it("should read error", () => {
             // act
-            let subject = new ErrorResponse({error:"foo"});
+            const subject = new ErrorResponse({error:"foo"});
 
             // assert
             expect(subject.error).toEqual("foo");
         });
 
         it("should read error_description", () => {
             // act
-            let subject = new ErrorResponse({error:"error", error_description:"foo"});
+            const subject = new ErrorResponse({error:"error", error_description:"foo"});
 
             // assert
             expect(subject.error_description).toEqual("foo");
         });
 
         it("should read error_uri", () => {
             // act
-            let subject = new ErrorResponse({error:"error", error_uri:"foo"});
+            const subject = new ErrorResponse({error:"error", error_uri:"foo"});
 
             // assert
             expect(subject.error_uri).toEqual("foo");
         });
 
         it("should read state", () => {
             // act
-            let subject = new ErrorResponse({error:"error", state:"foo"});
+            const subject = new ErrorResponse({error:"error", state:"foo"});
 
             // assert
             expect(subject.state).toEqual("foo");
@@ -57,15 +57,15 @@ describe("ErrorResponse", () => {
     describe("message", () => {
         it("should be description if set", () => {
             // act
-            let subject = new ErrorResponse({error:"error", error_description:"foo"});
+            const subject = new ErrorResponse({error:"error", error_description:"foo"});
 
             // assert
             expect(subject.message).toEqual("foo");
         });
 
         it("should be error if description not set", () => {
             // act
-            let subject = new ErrorResponse({error:"error"});
+            const subject = new ErrorResponse({error:"error"});
 
             // assert
             expect(subject.message).toEqual("error");
@@ -75,7 +75,7 @@ describe("ErrorResponse", () => {
     describe("name", () => {
         it("should be class name", () => {
             // act
-            let subject = new ErrorResponse({error:"error"});
+            const subject = new ErrorResponse({error:"error"});
 
             // assert
             expect(subject.name).toEqual("ErrorResponse");
@@ -85,7 +85,7 @@ describe("ErrorResponse", () => {
     describe("stack", () => {
         it("should be set", () => {
             // act
-            let subject = new ErrorResponse({error:"error"});
+            const subject = new ErrorResponse({error:"error"});
 
             // assert
             expect(subject.stack).not.toBeNull();

diff --git a/test/unit/JsonService.test.ts b/test/unit/JsonService.test.ts
@@ -1,12 +1,12 @@
 // Copyright (c) Brock Allen & Dominick Baier. All rights reserved.
 // Licensed under the Apache License, Version 2.0. See LICENSE in the project root for license information.
 
-import { Log } from '../../src/utils';
-import { JsonService } from '../../src/JsonService';
+import { Log } from "../../src/utils";
+import { JsonService } from "../../src/JsonService";
 
 describe("JsonService", () => {
     let subject: JsonService;
-    let fetchMock: jest.Mock<any, any>
+    let fetchMock: jest.Mock<any, any>;
 
     beforeEach(() =>{
         Log.logger = console;
@@ -22,44 +22,47 @@ describe("JsonService", () => {
 
         it("should return a promise", async () => {
             // act
-            let p = subject.getJson("http://test");
+            const p = subject.getJson("http://test");
 
             // assert
             expect(p).toBeInstanceOf(Promise);
+            // eslint-disable-next-line no-empty
             try { await p; } catch {}
         });
 
         it("should make GET request to url", async () => {
             // act
-            let p = subject.getJson("http://test");
+            const p = subject.getJson("http://test");
 
             // assert
-            expect(fetchMock).toBeCalledWith('http://test', {
+            expect(fetchMock).toBeCalledWith("http://test", {
                 headers: {},
-                method: 'GET'
+                method: "GET"
             });
+            // eslint-disable-next-line no-empty
             try { await p; } catch {}
         });
 
         it("should set token as authorization header", async () => {
             // act
-            let p = subject.getJson("http://test", "token");
+            const p = subject.getJson("http://test", "token");
 
             // assert
-            expect(fetchMock).toBeCalledWith('http://test', {
-                headers: { Authorization: 'Bearer token' },
-                method: 'GET'
+            expect(fetchMock).toBeCalledWith("http://test", {
+                headers: { Authorization: "Bearer token" },
+                method: "GET"
             });
+            // eslint-disable-next-line no-empty
             try { await p; } catch {}
         });
 
         it("should fulfill promise when http response is 200", async () => {
             // arrange
-            const json = { foo: 1, bar: 'test' };
+            const json = { foo: 1, bar: "test" };
             fetchMock.mockResolvedValue({
                 status: 200,
                 headers: new Headers({
-                    'Content-Type': 'application/json'
+                    "Content-Type": "application/json"
                 }),
                 json: () => Promise.resolve(json)
             });
@@ -84,8 +87,8 @@ describe("JsonService", () => {
                 fail("should not come here");
             } catch (error) {
                 expect(error).toBeInstanceOf(Error);
-                expect(error.message).toContain('500');
-                expect(error.message).toContain('server error');
+                expect(error.message).toContain("500");
+                expect(error.message).toContain("server error");
             }
         });
 
@@ -105,11 +108,11 @@ describe("JsonService", () => {
 
         it("should reject promise when http response content type is not json", async () => {
             // arrange
-            const json = { foo: 1, bar: 'test' };
+            const json = { foo: 1, bar: "test" };
             fetchMock.mockResolvedValue({
                 status: 200,
                 headers: new Headers({
-                    'Content-Type': 'text/html'
+                    "Content-Type": "text/html"
                 }),
                 json: () => Promise.resolve(json)
             });
@@ -126,18 +129,18 @@ describe("JsonService", () => {
 
         it("should accept custom content type in response", async () => {
             // arrange
-            subject = new JsonService(['foo/bar']);
-            const json = { foo: 1, bar: 'test' };
+            subject = new JsonService(["foo/bar"]);
+            const json = { foo: 1, bar: "test" };
             fetchMock.mockResolvedValue({
                 status: 200,
                 headers: new Headers({
-                    'Content-Type': 'foo/bar'
+                    "Content-Type": "foo/bar"
                 }),
                 json: () => Promise.resolve(json)
             });
 
             // act
-            let result = await subject.getJson("http://test");
+            const result = await subject.getJson("http://test");
 
             // assert
             expect(result).toEqual(json);