Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

layout issue with titlepage of German translation #77

Open
silberzwiebel opened this issue Aug 17, 2018 · 2 comments
Open

layout issue with titlepage of German translation #77

silberzwiebel opened this issue Aug 17, 2018 · 2 comments

Comments

@silberzwiebel
Copy link
Contributor

First of all: Thanks for merging!
Unfortunately, on the titlepage of the German translation the start button overlays the two-row text (since there was more than one person involved in translating). This also makes it impossible to click the link to the English original. I guess it's possible to move the button slightly down but I have basically zero experience in doing this code-wise.

sin added a commit to sin/crowds that referenced this issue Aug 17, 2018
@sin
Copy link
Contributor

sin commented Aug 17, 2018

Hi! I've created a quick fix that resolves this issue by moving the title and the gray text a little bit higher, this changes only the German translation. It's possible to move the button slightly down, but it would affect all translations (it would fix this issue in any upcoming translations and I think additional space when there's only one gray line wouldn't hurt either).

sin added a commit to sin/crowds that referenced this issue Aug 17, 2018
@silberzwiebel
Copy link
Contributor Author

Cool, thanks @sin. Would you mind to open a pull request so that your fix could go live?

ncase added a commit that referenced this issue Aug 27, 2018
Fix issue with titlepage of German translation (refs #77)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants