Fix XSS Vulnerability #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
icingaweb2-module-map is vulnerable to cross site scripting attacks via injected javascript, for example: map?default_lat=35.92464453144099&default_long=-120.38818359375001;alert(%27xss%20verified%27)&default_zoom=6&view=compact would inject a javascript payload. I've made a patch here to intval() variables that will only be ints, and then lat/long is filtered to only 0-9-., chars, and the rest just strip out '; chars so you can't escape out of the printed javascript.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
icingaweb2-module-map is vulnerable to cross site scripting attacks via injected javascript, for example:
map?default_lat=35.92464453144099&default_long=-120.38818359375001;alert(%27xss%20verified%27)&default_zoom=6&view=compact
would inject a javascript payload.
I've made a patch here to intval() variables that will only be ints, and then lat/long is filtered to only 0-9-., chars, and the rest just strip out '; chars so you can't escape out of the printed javascript.