Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update global.tokens.ts - darkmode fix #3633

Merged
merged 1 commit into from
Mar 6, 2025
Merged

Update global.tokens.ts - darkmode fix #3633

merged 1 commit into from
Mar 6, 2025

Conversation

sjur-gr
Copy link
Contributor

@sjur-gr sjur-gr commented Mar 6, 2025

Endret i darkmode

  • Brand Blue og Success, 100 - 400, endret saturation til 100.
  • Accent, 100 - 400, endret saturation til 60.
  • Alle farger 600, endret til kontraststop til 4.54:1. Bug, noen farger havnet under 4.5:1.
  • Alle farger 1000, endret saturation til 100.

Description

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation / Decision Records
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Endret i darkmode
Brand Blue og Success, 100 - 400, endret saturation til 100.
Accent, 100 - 400, endret saturation til 60.
Alle farger 600, endret til kontraststop til 4.52:1. Bug, noen farger havnet under 4.5:1.
Alle farger 1000, endret saturation til 100.
Copy link

changeset-bot bot commented Mar 6, 2025

⚠️ No Changeset found

Latest commit: 7908598

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Mar 6, 2025

Storybook demo / Chromatic

0f4178502 | 91 components | 135 stories

@KenAJoh KenAJoh merged commit abd5de2 into main Mar 6, 2025
6 checks passed
@KenAJoh KenAJoh deleted the sjur-gr-patch-2 branch March 6, 2025 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants