Fixed Tailwind 4 migration bugs, broken build #3532
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 50b11ef The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo / Chromatic📝 Changes to review: 730e5ad8f57 | 91 components | 135 stories |
JulianNymark
approved these changes
Jan 31, 2025
Comment on lines
18
to
+21
| /* In case Modal is opened with `show()`, in eg. Vergic screensharing */ | ||
| inset: 0; | ||
| z-index: 9999; | ||
| margin: auto; |
There was a problem hiding this comment.
Bør legges over kommentaren, siden det ikke har noe med kommentaren å gjøre.
Comment on lines
+12
to
+21
| *, | ||
| ::after, | ||
| ::before, | ||
| ::backdrop, | ||
| ::file-selector-button { | ||
| box-sizing: border-box; | ||
| margin: 0; | ||
| padding: 0; | ||
| border: 0 solid; | ||
| } |
There was a problem hiding this comment.
Vil ikke dette kunne brekke en del for de som lener seg på user agent stylesheet?
There was a problem hiding this comment.
Stemmer, fjernet det på main 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tailwind 4 sets
margin: 0´ andpadding: 0on every element. This causedinset: 0` to no longer work for Modal.margin: autoon ModalTested by emulating the new Tailwind 4 base-sheet and running chromatic locally to check for discrepancies.
Component Checklist 📝
@navikt/core/css/config/_mappings.js)@navikt/core/css/tokens.json)@navikt/aksel-stylelint/src/deprecations.ts)@navikt/core/react/src/index.tsand@navikt/core/react/package.json)@navikt/core/css/index.css)<Component>: <gitmoji?> <Text>.E.g. "Button: ✨ Add feature xyz.")