-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Datepicker] Bumped react-day-picker
to v9.
#3525
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 91210f7 The changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demo / Chromatic📝 Changes to review: 11a5783362 | 91 components | 135 stories |
KenAJoh
commented
Jan 27, 2025
@navikt/core/react/src/date/datepicker/parts/DatePicker.RDP.tsx
Outdated
Show resolved
Hide resolved
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As a result users will now not get peer-dependency warnings when running
npm install
sincerdp
v9 hasreact: ">= 16.8.0"
setWhile the upgrade-guide doesn't look that bad: https://daypicker.dev/upgrading, this major-update came with a bunch of small undocumented changes and gotchas 😭 In the end it turned into a refactor of most of our Datepicker and MonthPicker-code. While it looks like a lot has been done, most of the touched files are just small refactors like renaming and re-structuring.
Steps taken to ensure backwards compat and no breaking changes
Highlights
fixedWeeks
set/context
-dir code is now co-located and use our owncreateContext
-util where possibleclamp-dates
to make sure shown month/year is never "outside" the possible view./utils
->/date-utils
for clarityDatePicker.test.stories.tsx
andMonthPicker.test.stories.tsx
for testing code while refactoring.rdp
. The major updated how all of these worked so needed to be built from scratch. Notice that they now haveuseCallback
when used to avoid re-renders.ReactDayPicker
component itself to be re-used between standalone and dialog-versionreact-day-picker
, some utilities have been extractedMonthPicker
Component could no longer use old utilities from
rdp
. We didn't use it for much before anyways, so features were extracted and replicated locally.Component Checklist 📝
@navikt/core/css/config/_mappings.js
)@navikt/core/css/tokens.json
)@navikt/aksel-stylelint/src/deprecations.ts
)@navikt/core/react/src/index.ts
and@navikt/core/react/package.json
)@navikt/core/css/index.css
)<Component>: <gitmoji?> <Text>.
E.g. "Button: ✨ Add feature xyz.")