Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Linting] Eslint v9 dependency upgrades #3248

Merged
merged 6 commits into from
Oct 18, 2024
Merged

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Oct 17, 2024

Description

Looked up all our eslint-packages and checked their compat with Eslint v9.
Besides eslint-plugin-storybook and eslint-plugin-testing-library it looks like every other package now supports it. Could consider removing eslint-plugin-testing-library if @vitest/eslint-plugin handles most of it anyways

useDescendant update

Because of this change i had to update the component-names
facebook/react#25162

Component Checklist 📝

  • JSDoc
  • Examples
  • Documentation
  • Storybook
  • Style mappings (@navikt/core/css/config/_mappings.js)
  • Component tokens (@navikt/core/css/tokens.json)
  • CSS class deprecations (@navikt/aksel-stylelint/src/deprecations.ts)
  • Exports (@navikt/core/react/src/index.ts and @navikt/core/react/package.json)
  • New component? CSS import (@navikt/core/css/index.css)
  • Breaking change? Update migration guide. Consider codemod.
  • Changeset (Format: <Component>: <gitmoji?> <Text>. E.g. "Button: ✨ Add feature xyz.")

Copy link

changeset-bot bot commented Oct 17, 2024

⚠️ No Changeset found

Latest commit: 8ca1225

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 17, 2024

Storybook demo

082663c03 | 91 komponenter | 144 stories

@HalvorHaugan
Copy link
Contributor

I think we can live without eslint-plugin-storybook, at least temporarily.

HalvorHaugan
HalvorHaugan previously approved these changes Oct 18, 2024
@KenAJoh KenAJoh merged commit 7138b52 into main Oct 18, 2024
3 checks passed
@KenAJoh KenAJoh deleted the eslint-v9-dep-upgrades branch October 18, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants