Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update-article-views: Use latest docker image + remove reduntant stuff in workflow #3189

Merged
merged 7 commits into from
Oct 3, 2024
Merged

update-article-views: Use latest docker image + remove reduntant stuff in workflow #3189

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
d41575b
Update docker image for update-article-views
HalvorHaugan Oct 1, 2024
88d50e8
try distroless
HalvorHaugan Oct 1, 2024
49785be
trying latest
HalvorHaugan Oct 1, 2024
2d33b77
this cache seems to not be in use
HalvorHaugan Oct 1, 2024
5ac964e
do we need this?
HalvorHaugan Oct 1, 2024
a0ce193
don't think we need packages premission
HalvorHaugan Oct 1, 2024
0ae2886
contents permission should be default
HalvorHaugan Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions .github/workflows/update-article-views.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,24 +5,11 @@ jobs:
execute:
runs-on: ubuntu-latest
permissions:
packages: "write"
contents: "read"
id-token: "write"
steps:
- uses: actions/checkout@v4
with:
fetch-depth: 1
- uses: denoland/setup-deno@v1
with:
deno-version: v1.x
- name: Restore cache
uses: actions/cache@v4
with:
path: "**/node_modules"
key: ${{ runner.os }}-build-${{ github.sha }}
restore-keys: |
${{ runner.os }}-build-

- uses: nais/docker-build-push@v0
id: docker-push
with:
Expand Down
2 changes: 1 addition & 1 deletion scripts/article-views/Dockerfile.update-article-views
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM denoland/deno:1.40.2
FROM denoland/deno:latest

WORKDIR /app
RUN chown -R deno:deno /app
Expand Down