-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added prop for hidden heading to allow screen-readers to navigate to pagination #2976
Conversation
🦋 Changeset detectedLatest commit: bf9a269 The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 160a8bf83b | 84 komponenter | 172 stories |
Does the heading-propname make sense her? Since the heading is hidden with visuallyHidden, should it reflect that in the name? If so, any suggestions? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Has Morten tested it?
Good question. I didn't think about it when reviewing (probably b.c. I already new that it was going to be hidden after reading the PR title), but now that you mention it, it should probably reflect that in the name, yes. What about "srHeading"? |
Description
Also omitted
page
-attrb to bleed out to domResolves #2322