Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added prop for hidden heading to allow screen-readers to navigate to pagination #2976

Merged
merged 7 commits into from
Jun 7, 2024

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Jun 4, 2024

Description

Also omitted page-attrb to bleed out to dom

Resolves #2322

Copy link

changeset-bot bot commented Jun 4, 2024

🦋 Changeset detected

Latest commit: bf9a269

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Minor
@navikt/ds-css Minor
@navikt/ds-tokens Minor
@navikt/ds-tailwind Minor
@navikt/aksel-icons Minor
@navikt/aksel Minor
@navikt/aksel-stylelint Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jun 4, 2024

Storybook demo

Endringer til review: 1

60a8bf83b | 84 komponenter | 172 stories

@KenAJoh
Copy link
Collaborator Author

KenAJoh commented Jun 5, 2024

Does the heading-propname make sense her? Since the heading is hidden with visuallyHidden, should it reflect that in the name? If so, any suggestions?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has Morten tested it?

@HalvorHaugan
Copy link
Contributor

Does the heading-propname make sense her? Since the heading is hidden with visuallyHidden, should it reflect that in the name? If so, any suggestions?

Good question. I didn't think about it when reviewing (probably b.c. I already new that it was going to be hidden after reading the PR title), but now that you mention it, it should probably reflect that in the name, yes. What about "srHeading"?

@KenAJoh KenAJoh merged commit f1707fe into main Jun 7, 2024
5 checks passed
@KenAJoh KenAJoh deleted the pagination-heading branch June 7, 2024 09:26
@github-actions github-actions bot mentioned this pull request Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: <Pagination />
3 participants