Datepicker/MonthPicker required bugs #2838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d455a3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Storybook demoEndringer til review: 1dbc14de11 | 60 komponenter | 199 stories |
@navikt/core/react/src/date/monthpicker/monthpicker.stories.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
HalvorHaugan
previously approved these changes
Apr 11, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Resolves #2829
MonthPicker sin "required"-prop gjorde ingenting. Fikset nå med at det returneres tidlig hvis knapp allerede er valgt og man klikker på den.
For Datepicker var problemet at onChange-event ++ ble kjørt når den ikke burde.
A11y
Oppdaget at react-day-picker bruker
aria-selectedpå knappene, noe som ikke er lov. Riktig syntax for knapper eraria-pressedsom Date og Month-pickers er oppdatert til å bruke nå. For MonthPicker vil dette være en stor forbedring da den ikke hadde noe selected/pressed fra før.