Ny hook useMergeRefs som erstatter mergeRefs
#2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: aae0bec The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
KenAJoh
commented
Jan 11, 2024
| @@ -78,18 +78,18 @@ export const ShowMore = forwardRef<HTMLElement, ShowMoreProps>( | |||
| "aria-labelledby": ariaLabelledby, | |||
| ...rest | |||
| }, | |||
| ref, | |||
| /* ref, */ | |||
There was a problem hiding this comment.
Siden dette skal være tilnærmet en 1-1 kopi av en faktisk ds-react komponent komenterte jeg bare ref ut her siden den ikke blir brukt lokalt på nettsiden
Storybook demo7ed24e2d6 | 61 komponenter | 401 stories |
HalvorHaugan
previously approved these changes
Jan 12, 2024
Co-authored-by: Halvor Haugan <83693529+HalvorHaugan@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Vi bruker
mergeRefsen del rundt i prosjektet, men må wrappe iuseMemohver gang. HookenuseMergeRefsløser det for oss med å kjøre det gjennomuseCallbackGjorde et git-søk og fant ingen andre som brukte
mergeRefsfra@navikt/ds-reactså fjernet den fraindex-export. Vi får evt vurdere om vi har lyst å exponere hooks og utilities på en mer strukturert måte i fremtiden.