Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎨 Skeleton as-prop #2239

Merged
merged 4 commits into from
Sep 6, 2023
Merged

🎨 Skeleton as-prop #2239

merged 4 commits into from
Sep 6, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Sep 5, 2023

Description

Resolves #2233

Skeleton kan i dag ikke bli brukt inline i tekst på grunn av display: block og ugyldig dom-validering med p -> div.

Change summary

  • Fjernet display: block fra CSS. Nettleser setter dette som default. Span får da automatisk display: inline
  • La til as-prop med "div" | "span"

Screenshot 2023-09-05 at 10 37 47

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

🦋 Changeset detected

Latest commit: 2521b2e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@navikt/ds-react Patch
@navikt/ds-css Patch
@navikt/aksel-stylelint Patch
@navikt/aksel Patch
@navikt/ds-tokens Patch
@navikt/ds-tailwind Patch
@navikt/aksel-icons Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Storybook demo

Endringer til review: 1

d20771150 | 54 komponenter | 357 stories

@KenAJoh KenAJoh merged commit 4e05993 into main Sep 6, 2023
@KenAJoh KenAJoh deleted the skeleton-as branch September 6, 2023 09:03
@github-actions github-actions bot mentioned this pull request Sep 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Innspill til komponent]: <Skeleton />
1 participant