Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tokens] Breakpoint-tokens #1832

Merged
merged 8 commits into from
Mar 1, 2023
Merged

[Tokens] Breakpoint-tokens #1832

merged 8 commits into from
Mar 1, 2023

Conversation

KenAJoh
Copy link
Collaborator

@KenAJoh KenAJoh commented Mar 1, 2023

  • Oppdatere bruk av breakpoints på aksel.nav.no, bruker nå egen config (gjelder bare sm)

Down-variant er ment for bruk i "desktop-first" løsninger, eks max-width: 1279px eller løsninger der man ønsker et spesifikt brekkpunkt min-width: 1024px and max-width: 1279px.

Har valgt å gå for px verdier for enklere implementasjon vs rem, em da sistnevnte har problemer med browser-støtte (spesielt safari).

--a-breakpoint-xl-down: 1279px;
--a-breakpoint-xl: 1280px;
--a-breakpoint-lg-down: 1023px;
--a-breakpoint-lg: 1024px;
--a-breakpoint-md-down: 767px;
--a-breakpoint-md: 768px;
--a-breakpoint-sm-down: 479px;
--a-breakpoint-sm: 480px;
--a-breakpoint-xs: 0;

Tailwind-config

Med unntak av sm er alle tokens de samme som tailwind tilbyr som default. I NAV er det 3 prosjekt som bruker sm i koden sin og vår tailwind pakke, noe som vil være en breaking change. Men de er ikke på v2 enda, så legger bare til dokumentasjon om breaking change og noe i migreringsguiden slik at det ikke blir et problem

"screen": {
  "sm": "480px",
  "md": "768px",
  "lg": "1024px",
  "xl": "1280px"
},

@changeset-bot
Copy link

changeset-bot bot commented Mar 1, 2023

🦋 Changeset detected

Latest commit: 52334e5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 8 packages
Name Type
@navikt/ds-tailwind Minor
@navikt/ds-tokens Minor
@navikt/ds-css Minor
@navikt/ds-react Minor
@navikt/ds-icons Minor
@navikt/ds-css-internal Minor
@navikt/ds-react-internal Minor
@navikt/ds-codemod Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 1, 2023

Endringer til review: 1

81acf0b3d | 45 komponenter | 250 stories

@KenAJoh KenAJoh merged commit 8893b5c into main Mar 1, 2023
@KenAJoh KenAJoh deleted the breakpoints-reloaded branch March 1, 2023 16:10
@github-actions github-actions bot mentioned this pull request Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant