Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark internal classes with @internal #149

Closed
navispatial opened this issue Aug 16, 2022 · 1 comment
Closed

Mark internal classes with @internal #149

navispatial opened this issue Aug 16, 2022 · 1 comment
Labels
🌎 geodata Related to the code package "geodata" 🌐 geobase Related to the code package "geobase" 🌐 geocore Related to the code package "geocore" refactoring

Comments

@navispatial
Copy link
Member

See tweet by Remi Rousselet.

The @internal meta tag is "used to annotate a declaration which should only be used from within the package in which it is declared, and which should not be exposed from said package's public API."

Very nice!

At least classes on utils parts in this repository should be marked.
@navispatial navispatial added 🌐 geocore Related to the code package "geocore" 🌎 geodata Related to the code package "geodata" refactoring 🌐 geobase Related to the code package "geobase" labels Aug 16, 2022
navispatial added a commit that referenced this issue Aug 21, 2022
@navispatial
refactor: mark internal classes with @internal #149
934e36a
@navispatial
Copy link
Member Author

Implemented in release published at 2022-08-21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🌎 geodata Related to the code package "geodata" 🌐 geobase Related to the code package "geobase" 🌐 geocore Related to the code package "geocore" refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@navispatial